mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -next] drbd: fix error return code in drbd_init()
@ 2013-04-04  6:17 Wei Yongjun
  2013-04-04 18:58 ` [Drbd-dev] " Lars Ellenberg
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-04-04  6:17 UTC (permalink / raw)
  To: drbd-dev; +Cc: yongjun_wei, drbd-user, linux-kernel

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Fix to return a negative error code from the error handling
case instead of 0, as returned elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 drivers/block/drbd/drbd_main.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/block/drbd/drbd_main.c b/drivers/block/drbd/drbd_main.c
index 1b93a726..768bca9 100644
--- a/drivers/block/drbd/drbd_main.c
+++ b/drivers/block/drbd/drbd_main.c
@@ -2777,6 +2777,7 @@ int __init drbd_init(void)
 	drbd_proc = proc_create_data("drbd", S_IFREG | S_IRUGO , NULL, &drbd_proc_fops, NULL);
 	if (!drbd_proc)	{
 		printk(KERN_ERR "drbd: unable to register proc file\n");
+		err = -ENOMEM;
 		goto fail;
 	}
 
@@ -2786,6 +2787,7 @@ int __init drbd_init(void)
 	retry.wq = create_singlethread_workqueue("drbd-reissue");
 	if (!retry.wq) {
 		printk(KERN_ERR "drbd: unable to create retry workqueue\n");
+		err = -ENOMEM;
 		goto fail;
 	}
 	INIT_WORK(&retry.worker, do_retry);


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-04-04 18:58 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-04  6:17 [PATCH -next] drbd: fix error return code in drbd_init() Wei Yongjun
2013-04-04 18:58 ` [Drbd-dev] " Lars Ellenberg

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®