* [PATCH] mfd: syscon: Add missing struct device_node declaration
@ 2013-03-25 16:56 Sylwester Nawrocki
2013-03-26 7:27 ` Dong Aisheng
2013-04-09 9:51 ` Samuel Ortiz
0 siblings, 2 replies; 3+ messages in thread
From: Sylwester Nawrocki @ 2013-03-25 16:56 UTC (permalink / raw)
To: sameo; +Cc: kyungmin.park, linux-kernel, Sylwester Nawrocki, Dong Aisheng
syscon.h header uses struct device_node in functions' declarations
without declaring it. This causes compilation warnings like:
include/linux/mfd/syscon.h:20: warning: ‘struct device_node’
declared inside parameter list
include/linux/mfd/syscon.h:20: warning: its scope is only this
definition or declaration, which is probably not what you want
Fix it by adding a forward declaration of struct device_node.
Cc: Dong Aisheng <dong.aisheng@linaro.org>
Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
---
include/linux/mfd/syscon.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
index 6aeb6b8..f7be936 100644
--- a/include/linux/mfd/syscon.h
+++ b/include/linux/mfd/syscon.h
@@ -15,6 +15,8 @@
#ifndef __LINUX_MFD_SYSCON_H__
#define __LINUX_MFD_SYSCON_H__
+struct device_node;
+
extern struct regmap *syscon_node_to_regmap(struct device_node *np);
extern struct regmap *syscon_regmap_lookup_by_compatible(const char *s);
extern struct regmap *syscon_regmap_lookup_by_phandle(
--
1.7.9.5
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: syscon: Add missing struct device_node declaration
2013-03-25 16:56 [PATCH] mfd: syscon: Add missing struct device_node declaration Sylwester Nawrocki
@ 2013-03-26 7:27 ` Dong Aisheng
2013-04-09 9:51 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Dong Aisheng @ 2013-03-26 7:27 UTC (permalink / raw)
To: Sylwester Nawrocki; +Cc: sameo, kyungmin.park, linux-kernel
On 26 March 2013 00:56, Sylwester Nawrocki <s.nawrocki@samsung.com> wrote:
> syscon.h header uses struct device_node in functions' declarations
> without declaring it. This causes compilation warnings like:
>
> include/linux/mfd/syscon.h:20: warning: ‘struct device_node’
> declared inside parameter list
> include/linux/mfd/syscon.h:20: warning: its scope is only this
> definition or declaration, which is probably not what you want
>
> Fix it by adding a forward declaration of struct device_node.
>
> Cc: Dong Aisheng <dong.aisheng@linaro.org>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Acked-by: Dong Aisheng <dong.aisheng@linaro.org>
Regards
Dong Aisheng
> ---
> include/linux/mfd/syscon.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/mfd/syscon.h b/include/linux/mfd/syscon.h
> index 6aeb6b8..f7be936 100644
> --- a/include/linux/mfd/syscon.h
> +++ b/include/linux/mfd/syscon.h
> @@ -15,6 +15,8 @@
> #ifndef __LINUX_MFD_SYSCON_H__
> #define __LINUX_MFD_SYSCON_H__
>
> +struct device_node;
> +
> extern struct regmap *syscon_node_to_regmap(struct device_node *np);
> extern struct regmap *syscon_regmap_lookup_by_compatible(const char *s);
> extern struct regmap *syscon_regmap_lookup_by_phandle(
> --
> 1.7.9.5
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mfd: syscon: Add missing struct device_node declaration
2013-03-25 16:56 [PATCH] mfd: syscon: Add missing struct device_node declaration Sylwester Nawrocki
2013-03-26 7:27 ` Dong Aisheng
@ 2013-04-09 9:51 ` Samuel Ortiz
1 sibling, 0 replies; 3+ messages in thread
From: Samuel Ortiz @ 2013-04-09 9:51 UTC (permalink / raw)
To: Sylwester Nawrocki; +Cc: kyungmin.park, linux-kernel, Dong Aisheng
Hi Silwester,
On Mon, Mar 25, 2013 at 05:56:23PM +0100, Sylwester Nawrocki wrote:
> syscon.h header uses struct device_node in functions' declarations
> without declaring it. This causes compilation warnings like:
>
> include/linux/mfd/syscon.h:20: warning: ‘struct device_node’
> declared inside parameter list
> include/linux/mfd/syscon.h:20: warning: its scope is only this
> definition or declaration, which is probably not what you want
>
> Fix it by adding a forward declaration of struct device_node.
>
> Cc: Dong Aisheng <dong.aisheng@linaro.org>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> include/linux/mfd/syscon.h | 2 ++
> 1 file changed, 2 insertions(+)
Applied, thanks.
Cheers,
Samuel.
--
Intel Open Source Technology Centre
http://oss.intel.com/
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-04-09 9:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-25 16:56 [PATCH] mfd: syscon: Add missing struct device_node declaration Sylwester Nawrocki
2013-03-26 7:27 ` Dong Aisheng
2013-04-09 9:51 ` Samuel Ortiz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®