* [PATCH] fs: reiserfs: Use kstrdup function
@ 2013-04-12 1:20 Alexandru Gheorghiu
2013-04-15 11:52 ` Jan Kara
0 siblings, 1 reply; 2+ messages in thread
From: Alexandru Gheorghiu @ 2013-04-12 1:20 UTC (permalink / raw)
To: Jan Kara; +Cc: Al Viro, Artem Bityutskiy, linux-kernel, Alexandru Gheorghiu
Use kstrdup function instead of kmalloc and strcpy.
Patch found using coccinelle.
Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
---
fs/reiserfs/super.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
index 194113b..f8a23c3 100644
--- a/fs/reiserfs/super.c
+++ b/fs/reiserfs/super.c
@@ -1147,8 +1147,7 @@ static int reiserfs_parse_options(struct super_block *s, char *options, /* strin
"on filesystem root.");
return 0;
}
- qf_names[qtype] =
- kmalloc(strlen(arg) + 1, GFP_KERNEL);
+ qf_names[qtype] = kstrdup(arg, GFP_KERNEL);
if (!qf_names[qtype]) {
reiserfs_warning(s, "reiserfs-2502",
"not enough memory "
@@ -1156,7 +1155,6 @@ static int reiserfs_parse_options(struct super_block *s, char *options, /* strin
"quotafile name.");
return 0;
}
- strcpy(qf_names[qtype], arg);
if (qtype == USRQUOTA)
*mount_options |= 1 << REISERFS_USRQUOTA;
else
--
1.7.9.5
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] fs: reiserfs: Use kstrdup function
2013-04-12 1:20 [PATCH] fs: reiserfs: Use kstrdup function Alexandru Gheorghiu
@ 2013-04-15 11:52 ` Jan Kara
0 siblings, 0 replies; 2+ messages in thread
From: Jan Kara @ 2013-04-15 11:52 UTC (permalink / raw)
To: Alexandru Gheorghiu; +Cc: Jan Kara, Al Viro, Artem Bityutskiy, linux-kernel
On Fri 12-04-13 04:20:18, Alexandru Gheorghiu wrote:
> Use kstrdup function instead of kmalloc and strcpy.
> Patch found using coccinelle.
Thanks for the patch but I already have a similar patch in my tree.
Honza
>
> Signed-off-by: Alexandru Gheorghiu <gheorghiuandru@gmail.com>
> ---
> fs/reiserfs/super.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/fs/reiserfs/super.c b/fs/reiserfs/super.c
> index 194113b..f8a23c3 100644
> --- a/fs/reiserfs/super.c
> +++ b/fs/reiserfs/super.c
> @@ -1147,8 +1147,7 @@ static int reiserfs_parse_options(struct super_block *s, char *options, /* strin
> "on filesystem root.");
> return 0;
> }
> - qf_names[qtype] =
> - kmalloc(strlen(arg) + 1, GFP_KERNEL);
> + qf_names[qtype] = kstrdup(arg, GFP_KERNEL);
> if (!qf_names[qtype]) {
> reiserfs_warning(s, "reiserfs-2502",
> "not enough memory "
> @@ -1156,7 +1155,6 @@ static int reiserfs_parse_options(struct super_block *s, char *options, /* strin
> "quotafile name.");
> return 0;
> }
> - strcpy(qf_names[qtype], arg);
> if (qtype == USRQUOTA)
> *mount_options |= 1 << REISERFS_USRQUOTA;
> else
> --
> 1.7.9.5
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-04-16 16:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-04-12 1:20 [PATCH] fs: reiserfs: Use kstrdup function Alexandru Gheorghiu
2013-04-15 11:52 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®