From: Guenter Roeck <linux@roeck-us.net>
To: Jingoo Han <jg1.han@samsung.com>
Cc: "'Andrew Morton'" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"'Wim Van Sebroeck'" <wim@iguana.be>,
linux-watchdog@vger.kernel.org
Subject: Re: [PATCH RESEND 3/7] watchdog: mv64x60_wdt: use devm_ioremap()
Date: Mon, 29 Apr 2013 18:58:36 -0700 [thread overview]
Message-ID: <20130430015836.GB25984@roeck-us.net> (raw)
In-Reply-To: <000501ce4545$f43495f0$dc9dc1d0$@samsung.com>
On Tue, Apr 30, 2013 at 10:56:39AM +0900, Jingoo Han wrote:
> On Tuesday, April 30, 2013 2:55 AM, Guenter Roeck wrote:
> > On Mon, Apr 29, 2013 at 06:35:15PM +0900, Jingoo Han wrote:
> > > Use devm_ioremap() to make cleanup paths simpler.
> > >
> > > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> >
> > This patch also addresses the missing call to iounmap() if the call
> > to misc_register fails.
>
> When devm_ioremap() is used, there is no need to call devm_iounmap().
>
> It is because, these resource managed functions such as
> devm_ioremap() allow the driver core to automatically
> clean up any allocation, when probe function fails.
>
Same response as before. Please read my note above. It says clearly
"this patch _addresses_ ...", not "this patch _creates_ ...".
Guenter
next prev parent reply other threads:[~2013-04-30 1:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-29 9:35 Jingoo Han
2013-04-29 17:55 ` Guenter Roeck
2013-04-30 1:56 ` Jingoo Han
2013-04-30 1:58 ` Guenter Roeck [this message]
2013-05-02 5:51 Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130430015836.GB25984@roeck-us.net \
--to=linux@roeck-us.net \
--cc=akpm@linux-foundation.org \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®