From: Peter Zijlstra <peterz@infradead.org>
To: Julian Anastasov <ja@ssi.bg>
Cc: Simon Horman <horms@verge.net.au>,
Eric Dumazet <eric.dumazet@gmail.com>,
Ingo Molnar <mingo@redhat.com>,
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com>,
lvs-devel@vger.kernel.org, netdev@vger.kernel.org,
netfilter-devel@vger.kernel.org, linux-kernel@vger.kernel.org,
Pablo Neira Ayuso <pablo@netfilter.org>,
Dipankar Sarma <dipankar@in.ibm.com>
Subject: Re: [PATCH v2 1/2] sched: Add cond_resched_rcu_lock() helper
Date: Thu, 2 May 2013 09:26:24 +0200 [thread overview]
Message-ID: <20130502072623.GE7521@dyad.programming.kicks-ass.net> (raw)
In-Reply-To: <alpine.LFD.2.00.1305012004360.3397@ja.ssi.bg>
On Wed, May 01, 2013 at 09:22:08PM +0300, Julian Anastasov wrote:
> > +extern int __cond_resched_rcu(void);
> > +
> > +#define cond_resched_rcu() ({ \
> > + __might_sleep(__FILE__, __LINE__, 0); \
>
> I see your goal. But digging into __might_sleep()
> I see that rcu_sleep_check() will scream for the non-preempt
> case because we are under rcu_read_lock.
#ifdef CONFIG_PREEMPT_RCU
#define PREEMPT_RCU_OFFSET 0
#else
#define PREEMPT_RCU_OFFSET 1
#endif
#define cond_resched_rcu() ({ \
__might_sleep(__FILE__, __LINE__, PREEMPT_RCU_OFFSET); \
__cond_resched_rcu(); \
})
Should work I think..
next prev parent reply other threads:[~2013-05-02 7:28 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-30 2:52 [PATCH v2 0/2] " Simon Horman
2013-04-30 2:52 ` [PATCH v2 1/2] " Simon Horman
2013-04-30 7:12 ` Julian Anastasov
2013-04-30 7:29 ` Simon Horman
2013-04-30 7:52 ` Julian Anastasov
2013-05-01 9:10 ` Peter Zijlstra
2013-05-01 12:46 ` Paul E. McKenney
2013-05-01 14:32 ` Paul E. McKenney
2013-05-02 7:27 ` Peter Zijlstra
2013-05-01 15:17 ` Peter Zijlstra
2013-05-01 15:29 ` Eric Dumazet
2013-05-01 15:59 ` Peter Zijlstra
2013-05-01 16:02 ` Paul E. McKenney
2013-05-01 16:57 ` Peter Zijlstra
2013-05-01 17:30 ` Paul E. McKenney
2013-05-01 14:22 ` Julian Anastasov
2013-05-01 15:55 ` Peter Zijlstra
2013-05-01 18:22 ` Julian Anastasov
2013-05-01 19:04 ` Paul E. McKenney
2013-05-02 7:26 ` Peter Zijlstra [this message]
2013-05-02 10:06 ` Julian Anastasov
2013-05-02 15:54 ` Julian Anastasov
2013-05-02 17:32 ` Paul E. McKenney
2013-05-02 18:55 ` Julian Anastasov
2013-05-02 19:24 ` Julian Anastasov
2013-05-02 19:34 ` Paul E. McKenney
2013-05-02 20:19 ` Julian Anastasov
2013-05-02 22:31 ` Paul E. McKenney
2013-05-03 7:52 ` Julian Anastasov
2013-05-03 16:30 ` Paul E. McKenney
2013-05-03 17:04 ` Peter Zijlstra
2013-05-03 17:34 ` Paul E. McKenney
2013-05-03 18:09 ` Peter Zijlstra
2013-05-03 17:47 ` Julian Anastasov
2013-05-04 7:23 ` Julian Anastasov
2013-05-04 18:03 ` Paul E. McKenney
2013-04-30 2:52 ` [PATCH v2 2/2] ipvs: Use cond_resched_rcu_lock() helper when dumping connections Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130502072623.GE7521@dyad.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=dipankar@in.ibm.com \
--cc=eric.dumazet@gmail.com \
--cc=horms@verge.net.au \
--cc=ja@ssi.bg \
--cc=linux-kernel@vger.kernel.org \
--cc=lvs-devel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=paulmck@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®