mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ASoC: wm0010: fix error return code in wm0010_boot()
@ 2013-05-07 11:38 Wei Yongjun
  2013-05-07 13:54 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-05-07 11:38 UTC (permalink / raw)
  To: broonie, lgirdwood, perex, tiwai
  Cc: yongjun_wei, patches, alsa-devel, linux-kernel

From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>

Fix to return -ENOMEM in the memory malloc of 'out' and 'img_swap' error
handling case instead of 0, as done elsewhere in this function.

Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
 sound/soc/codecs/wm0010.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/soc/codecs/wm0010.c b/sound/soc/codecs/wm0010.c
index 8df2b6e..370af0c 100644
--- a/sound/soc/codecs/wm0010.c
+++ b/sound/soc/codecs/wm0010.c
@@ -667,6 +667,7 @@ static int wm0010_boot(struct snd_soc_codec *codec)
 		/* On wm0010 only the CLKCTRL1 value is used */
 		pll_rec.clkctrl1 = wm0010->pll_clkctrl1;
 
+		ret = -ENOMEM;
 		len = pll_rec.length + 8;
 		out = kzalloc(len, GFP_KERNEL);
 		if (!out) {


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: wm0010: fix error return code in wm0010_boot()
  2013-05-07 11:38 [PATCH] ASoC: wm0010: fix error return code in wm0010_boot() Wei Yongjun
@ 2013-05-07 13:54 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-05-07 13:54 UTC (permalink / raw)
  To: Wei Yongjun
  Cc: lgirdwood, perex, tiwai, yongjun_wei, patches, alsa-devel, linux-kernel

[-- Attachment #1: Type: text/plain, Size: 318 bytes --]

On Tue, May 07, 2013 at 07:38:52PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> 
> Fix to return -ENOMEM in the memory malloc of 'out' and 'img_swap' error
> handling case instead of 0, as done elsewhere in this function.

Applied, thanks.  Please note my new e-mail address.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2013-05-07 13:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-07 11:38 [PATCH] ASoC: wm0010: fix error return code in wm0010_boot() Wei Yongjun
2013-05-07 13:54 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®