Re: [PATCH 1/2] regulator: support operating mode in the device tree structure

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 864 bytes --]

On Tue, May 07, 2013 at 01:09:14PM +0000, Kim, Milo wrote:
> For better power efficiency, regulator subsystem provides operating mode.
> (fast, normal, idle and standby)
> The operating mode is selective by a regulator consumer.
> 
> With this patch, regulator operating mode can be set in the DT structure.
> If any operating mode is configured, then 'valid_ops_mask' should be set with
> REGULATOR_CHANGE_MODE.

It's not clear to me that these modes are a useful thing to be exposing
in device tree - they've always been rather arbatrary and are becoming
less and less relevant as regulator hardware improves in its ability to
adapt to load.  I think for fixed modes that don't vary dynamically at
runtime the best thing is just to make the modes custom so they map onto
the device datasheets clearly.  That seems to be most of the usage
anyway.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]