From: Mark Brown <broonie@kernel.org>
To: "Kim, Milo" <Milo.Kim@ti.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/2] regulator: support operating mode in the device tree structure
Date: Wed, 8 May 2013 12:12:10 +0100 [thread overview]
Message-ID: <20130508111210.GG7478@sirena.org.uk> (raw)
In-Reply-To: <A874F61F95741C4A9BA573A70FE3998F82E5C9C8@DQHE06.ent.ti.com>
[-- Attachment #1: Type: text/plain, Size: 824 bytes --]
On Tue, May 07, 2013 at 11:46:12PM +0000, Kim, Milo wrote:
> It's my intention to guarantee same operations in the DT as the regulator
> constraints in the platform side.
> In case a regulator has specific 'valid_modes_mask', the operating mode is
> unable to be set with the device tree.
> For some regulator drivers such as LP8720/5 and LP8788, this patch would be
> useful because there is no difference between configuration in the platform side
> and the device tree.
I understand what the patch is doing but there's no reason why the
device tree binding needs to map directly onto our internal
configuration and indeed in cases where we didn't make ideal choices
that's not what we want to do. Providing a binding that corresponds to
what the chip itself calls the configuration seems more useful.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-05-08 11:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-07 13:09 Kim, Milo
2013-05-07 16:04 ` Mark Brown
2013-05-07 23:46 ` Kim, Milo
2013-05-08 11:12 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130508111210.GG7478@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Milo.Kim@ti.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®