Re: [PATCH 4/9] perf tools: Add a precise event qualifier

[Jiri Olsa <jolsa@redhat.com>]

On Fri, May 10, 2013 at 10:43:28AM +0900, Namhyung Kim wrote:
> On Thu,  9 May 2013 15:32:19 +0200, Jiri Olsa wrote:
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > Add a precise qualifier, like cpu/event=0x3c,precise=1/
> >
> > This is needed so that the kernel can request enabling PEBS
> > for TSX events. The parser bails out on any sysfs parse errors,
> > so this is needed in any case to handle any event on the TSX
> > perf kernel.
> [SNIP]
> > --- a/tools/perf/util/parse-events.c
> > +++ b/tools/perf/util/parse-events.c
> > @@ -568,6 +568,12 @@ do {								\
> >  	case PARSE_EVENTS__TERM_TYPE_NAME:
> >  		CHECK_TYPE_VAL(STR);
> >  		break;
> > +	case PARSE_EVENTS__TERM_TYPE_PRECISE:
> > +		CHECK_TYPE_VAL(NUM);
> > +		if ((unsigned)term->val.num > 2)
> 
> Shouldn't it be 3 as we technically allow the 'ppp' modifier?  Although
> there's no cpu suppports precise=3 currently, things can be changed. :)

ok

jirka

> 
> Thanks,
> Namhyung
>