From: Neil Horman <nhorman@tuxdriver.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <andi@firstfloor.org>,
Colin Walters <walters@verbum.org>,
Denys Vlasenko <vda.linux@googlemail.com>,
Jiri Slaby <jslaby@suse.cz>,
Lennart Poettering <mzxreary@0pointer.de>,
Lucas De Marchi <lucas.de.marchi@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/6] coredump: format_corename() fixes/cleanups
Date: Thu, 16 May 2013 09:28:39 -0400 [thread overview]
Message-ID: <20130516132839.GA3430@neilslaptop.think-freely.org> (raw)
In-Reply-To: <20130515201158.GA14606@redhat.com>
On Wed, May 15, 2013 at 10:11:58PM +0200, Oleg Nesterov wrote:
> Hello.
>
> On 05/13, Oleg Nesterov wrote:
> >
> > With the patch below we can trivially fix the problem,
> >
> > + char *fmt = ispipe ? "\e%s\e" : "%s";
> > ...
> > - err = cn_printf(cn, "%s", current->comm);
> > + err = cn_printf(cn, fmt, current->comm);
> >
> > Or this ESC hack is too ugly or can break something?
>
> OK, nobody really nacked "[PATCH] teach argv_split() to ignore the spaces
> surrounded by \e", see http://marc.info/?l=linux-kernel&m=136845597401674
>
> I am going to send this patch "officially" and fix format_corename/argv_split
> interaction.
>
> But lets fix other format_corename() bugs first: leak and use-after-free.
> Plus some cleanups.
>
> Oleg.
>
> fs/coredump.c | 120 +++++++++++++++++++++++++++-----------------------------
> 1 files changed, 58 insertions(+), 62 deletions(-)
>
>
For the series
Acked-by: Neil Horman <nhorman@tuxdriver.com>
next prev parent reply other threads:[~2013-05-16 13:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-15 20:11 Oleg Nesterov
2013-05-15 20:12 ` [PATCH 1/6] coredump: format_corename() can leak cn->corename Oleg Nesterov
2013-05-15 20:12 ` [PATCH 2/6] coredump: introduce cn_vprintf() Oleg Nesterov
2013-05-15 20:12 ` [PATCH 3/6] coredump: cn_vprintf() has no reason to call vsnprintf() twice Oleg Nesterov
2013-05-15 20:12 ` [PATCH 4/6] coredump: kill cn_escape(), introduce cn_esc_printf() Oleg Nesterov
2013-05-15 20:26 ` [PATCH v2 " Oleg Nesterov
2013-05-15 20:12 ` [PATCH 5/6] coredump: kill call_count, add core_name_size Oleg Nesterov
2013-05-24 19:53 ` Andrew Morton
2013-05-27 15:16 ` Oleg Nesterov
2013-05-15 20:12 ` [PATCH 6/6] coredump: '% at the end' shouldn't bypass core_uses_pid logic Oleg Nesterov
2013-05-16 13:28 ` Neil Horman [this message]
[not found] ` <20130516154323.GA19060@redhat.com>
2013-05-16 15:43 ` [PATCH 1/1] usermodehelper: check subprocess_info->path != NULL Oleg Nesterov
2013-05-16 16:16 ` Lucas De Marchi
2013-05-16 17:13 ` Oleg Nesterov
[not found] ` <20130516182624.GA29455@redhat.com>
2013-05-16 18:38 ` [PATCH 7/6] coredump: avoid the uninitialized cn->corename if core_pattern is empty Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130516132839.GA3430@neilslaptop.think-freely.org \
--to=nhorman@tuxdriver.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=jslaby@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.de.marchi@gmail.com \
--cc=mzxreary@0pointer.de \
--cc=oleg@redhat.com \
--cc=vda.linux@googlemail.com \
--cc=walters@verbum.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®