From: Greg KH <gregkh@linuxfoundation.org>
To: Yuan-Hsin Chen <yuanlmm@gmail.com>
Cc: stern@rowland.harvard.edu, sarah.a.sharp@linux.intel.com,
balbi@ti.com, Julia.Lawall@lip6.fr, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org,
Yuan-Hsin Chen <yhchen@faraday-tech.com>
Subject: Re: [PATCH v4] usb host: Faraday USB2.0 FUSBH200-HCD driver
Date: Thu, 16 May 2013 17:45:11 -0700 [thread overview]
Message-ID: <20130517004511.GA10492@kroah.com> (raw)
In-Reply-To: <1366969040-28892-1-git-send-email-yhchen@faraday-tech.com>
On Fri, Apr 26, 2013 at 09:37:20AM +0000, Yuan-Hsin Chen wrote:
> FUSBH200-HCD is an USB2.0 hcd for Faraday FUSBH200.
> FUSBH200 is an ehci-like controller with some differences.
> First, register layout of FUSBH200 is incompatible with EHCI.
> Furthermore, FUSBH200 is lack of siTDs which means iTDs
> are used for both HS and FS ISO transfer.
>
> Signed-off-by: Yuan-Hsin Chen <yhchen@faraday-tech.com>
This patch breaks the build on my machine, so I can't accept it:
CC [M] drivers/usb/host/fusbh200-hcd.o
drivers/usb/host/fusbh200-hcd.c: In function ‘dbg_hcc_params’:
drivers/usb/host/fusbh200-hcd.c:149:2: error: implicit declaration of function ‘HCC_HW_PREFETCH’ [-Werror=implicit-function-declaration]
drivers/usb/host/fusbh200-hcd.c:149:2: error: implicit declaration of function ‘HCC_32FRAME_PERIODIC_LIST’ [-Werror=implicit-function-declaration]
drivers/usb/host/fusbh200-hcd.c:149:2: warning: format ‘%d’ expects argument of type ‘int’, but argument 6 has type ‘char *’ [-Wformat]
drivers/usb/host/fusbh200-hcd.c: At top level:
drivers/usb/host/fusbh200-hcd.c:906:12: warning: ‘debug_lpm_close’ defined but not used [-Wunused-function]
cc1: some warnings being treated as errors
Please be more careful. Can you fix this up and resend it?
thanks,
greg k-h
next prev parent reply other threads:[~2013-05-17 3:42 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-06 11:24 [PATCH] usb host: Faraday FUSBH200 HCD driver Yuan-Hsin Chen
2013-02-06 15:46 ` Alan Stern
2013-02-06 16:38 ` Felipe Balbi
2013-02-07 3:03 ` Yuan-Hsin Chen
2013-03-18 10:06 ` Yuan-Hsin Chen
2013-03-18 10:18 ` Felipe Balbi
2013-03-18 14:16 ` Alan Stern
2013-03-18 18:23 ` Felipe Balbi
2013-03-18 18:47 ` Alan Stern
2013-03-19 10:14 ` Yuan-Hsin Chen
2013-03-19 15:48 ` Alan Stern
2013-03-20 5:50 ` Yuan-Hsin Chen
2013-03-20 13:24 ` Yuan-Hsin Chen
2013-03-20 14:26 ` Alan Stern
2013-03-21 6:35 ` Yuan-Hsin Chen
2013-04-01 7:53 ` [PATCH v2] " Yuan-Hsin Chen
2013-04-16 12:43 ` [PATCH v3] usb host: Faraday USB2.0 FUSBH200-HCD driver Yuan-Hsin Chen
2013-04-26 9:37 ` [PATCH v4] " Yuan-Hsin Chen
2013-05-08 12:39 ` Yuan-Hsin Chen
2013-05-08 14:40 ` Alan Stern
2013-05-08 15:11 ` Yuan-Hsin Chen
2013-05-08 15:39 ` Greg KH
2013-05-17 0:45 ` Greg KH [this message]
2013-05-17 10:03 ` Yuan-Hsin Chen
2013-05-17 10:14 ` [PATCH v5] " Yuan-Hsin Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130517004511.GA10492@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Julia.Lawall@lip6.fr \
--cc=balbi@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=sarah.a.sharp@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=yhchen@faraday-tech.com \
--cc=yuanlmm@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome