From: Mark Brown <broonie@kernel.org>
To: Andrew Bresticker <abrestic@chromium.org>
Cc: alsa-devel@alsa-project.org, Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.de>,
Sachin Kamat <sachin.kamat@linaro.org>,
Ralph Birt <ralph.birt@maximintegrated.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: max98090: request IRQF_ONESHOT interrupt
Date: Mon, 20 May 2013 08:01:13 -0500 [thread overview]
Message-ID: <20130520130113.GU1627@sirena.org.uk> (raw)
In-Reply-To: <1369029487-32702-1-git-send-email-abrestic@chromium.org>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Sun, May 19, 2013 at 10:58:07PM -0700, Andrew Bresticker wrote:
> request_threaded_irq() rejects calls which both do not specify a handler
> (indicating that the primary IRQ handler should be used) and do not set
> IRQF_ONESHOT because the combination is unsafe with level-triggered
> interrupts. It is safe in this case, though, since max98090 IRQs are
Applied, thanks. If request_threaded_irq() is rejecting these that's
not ideal - some threaded interrupts can only be generated from within
threaded context and therefore can't have primary handlers. Unless it
only rejects in the case where the parent IRQ is a hard IRQ of course.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-05-20 13:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-20 5:58 Andrew Bresticker
2013-05-20 13:01 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130520130113.GU1627@sirena.org.uk \
--to=broonie@kernel.org \
--cc=abrestic@chromium.org \
--cc=alsa-devel@alsa-project.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ralph.birt@maximintegrated.com \
--cc=sachin.kamat@linaro.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®