Re: [PATCH] regulator: 88pm800: add regulator driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 894 bytes --]

On Tue, May 28, 2013 at 10:32:09AM +0800, yi zhang wrote:

> HI, Brown:

In western culture it's either "Hi Mark" or "Hi Mr Brown" (though the
latter is pretty formal so not used much for things like mailing lists).

>           Sorry I'm a little confused:
>           You mean I should use a function for example
> "create_buck_table()" to create the BUCK voltage table?
>            such as:
>            void create_buck_table()
>            {
>                    if (voltage < 1587500) {
>                              /* initialize the BUCK_table */
>                    } else
>                              /* initialize the BUCK_table */
>            }

No, I mean you shouldn't be using a table at all but have mapping and
list functions which just do the calculation required to generate the
tables directly.  This saves scanning through the table as direct
calcuation is possible.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]