From: Mark Brown <broonie@kernel.org>
To: Chao Xie <cxie4@marvell.com>
Cc: yi zhang <yizhang.mrvl@gmail.com>,
Liam Girdwood <lgirdwood@gmail.com>,
"jett.zhou@marvell.com" <jett.zhou@marvell.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Yi Zhang <yizhang@marvell.com>
Subject: Re: [PATCH] regulator: 88pm800: add regulator driver
Date: Tue, 28 May 2013 10:20:40 -0400 [thread overview]
Message-ID: <20130528142040.GI3660@sirena.org.uk> (raw)
In-Reply-To: <AAD1C6EB06EE3649B35B7E026785068D2581253EA9@SC-VEXCH2.marvell.com>
[-- Attachment #1: Type: text/plain, Size: 647 bytes --]
On Tue, May 28, 2013 at 05:10:00AM -0700, Chao Xie wrote:
Please fix your mail client to word wrap within paragraphs.
> Thanks for your review.
> Because structure regulator_desc only accepts the voltage table as constant.
> struct regulator_desc {
> ...
> const unsigned int *volt_table;
> ...
> };
> If we want to make use of the volt_table, and the help functions regulator_map_voltage_iterate and regulator_list_voltage_table, we have to initialize the tables as what we do now.
If you are calculating this stuff you shouldn't be providing a voltage
table at all. The whole point is that these things shouldn't be using
voltage tables.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
prev parent reply other threads:[~2013-05-28 14:20 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-22 12:10 yizhang.mrvl
2013-05-22 16:14 ` Mark Brown
2013-05-24 3:01 ` yi zhang
2013-05-25 19:56 ` Mark Brown
2013-05-28 2:32 ` yi zhang
2013-05-28 10:04 ` Mark Brown
2013-05-28 12:10 ` Chao Xie
2013-05-28 14:20 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130528142040.GI3660@sirena.org.uk \
--to=broonie@kernel.org \
--cc=cxie4@marvell.com \
--cc=jett.zhou@marvell.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=yizhang.mrvl@gmail.com \
--cc=yizhang@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®