* [PATCH] regulator: palmas: Fix "enable_reg" to point to the correct reg for SMPS10
@ 2013-05-30 10:25 Kishon Vijay Abraham I
2013-05-30 10:56 ` Mark Brown
0 siblings, 1 reply; 2+ messages in thread
From: Kishon Vijay Abraham I @ 2013-05-30 10:25 UTC (permalink / raw)
To: lgirdwood, broonie, linux-kernel; +Cc: kishon, balbi, gg
regulator_enable_regmap() uses enable_reg to enable the regulator.
But enable_reg for smps10 points to SMPS10_STATUS which is a
read-only register. Fixed the same by having enable_reg
set to SMPS10_CTRL.
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
---
drivers/regulator/palmas-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/palmas-regulator.c b/drivers/regulator/palmas-regulator.c
index 92ceed0..87d4f13 100644
--- a/drivers/regulator/palmas-regulator.c
+++ b/drivers/regulator/palmas-regulator.c
@@ -878,7 +878,7 @@ static int palmas_regulators_probe(struct platform_device *pdev)
pmic->desc[id].vsel_mask = SMPS10_VSEL;
pmic->desc[id].enable_reg =
PALMAS_BASE_TO_REG(PALMAS_SMPS_BASE,
- PALMAS_SMPS10_STATUS);
+ PALMAS_SMPS10_CTRL);
pmic->desc[id].enable_mask = SMPS10_BOOST_EN;
pmic->desc[id].min_uV = 3750000;
pmic->desc[id].uV_step = 1250000;
--
1.7.10.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] regulator: palmas: Fix "enable_reg" to point to the correct reg for SMPS10
2013-05-30 10:25 [PATCH] regulator: palmas: Fix "enable_reg" to point to the correct reg for SMPS10 Kishon Vijay Abraham I
@ 2013-05-30 10:56 ` Mark Brown
0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2013-05-30 10:56 UTC (permalink / raw)
To: Kishon Vijay Abraham I; +Cc: lgirdwood, linux-kernel, balbi, gg
[-- Attachment #1: Type: text/plain, Size: 302 bytes --]
On Thu, May 30, 2013 at 03:55:09PM +0530, Kishon Vijay Abraham I wrote:
> regulator_enable_regmap() uses enable_reg to enable the regulator.
> But enable_reg for smps10 points to SMPS10_STATUS which is a
> read-only register. Fixed the same by having enable_reg
> set to SMPS10_CTRL.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-05-30 10:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-30 10:25 [PATCH] regulator: palmas: Fix "enable_reg" to point to the correct reg for SMPS10 Kishon Vijay Abraham I
2013-05-30 10:56 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®