mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wim Van Sebroeck <wim@iguana.be>
To: Guenter Roeck <linux@roeck-us.net>
Cc: Don Zickus <dzickus@redhat.com>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	linux-watchdog@vger.kernel.org, kexec@lists.infradead.org,
	LKML <linux-kernel@vger.kernel.org>,
	vgoyal@redhat.com, dyoung@redhat.com
Subject: Re: [PATCH v3] watchdog: Add hook for kicking in kdump path
Date: Thu, 30 May 2013 23:54:14 +0200	[thread overview]
Message-ID: <20130530215414.GK14258@spo001.leaseweb.com> (raw)
In-Reply-To: <20130528153452.GA21891@roeck-us.net>

Hi Guenter,

> > Only when you set the .parent field in the watchdog_device data you will get the
> > referal in the /sys/class/... tree. In iTCO_wdt.c you have the following code
> > that does that: iTCO_wdt_watchdog_dev.parent = dev->dev.parent;
> > 
> > From the watchdog-kernel-api documentation:
> > * parent: set this to the parent device (or NULL) before calling
> >   watchdog_register_device.
> > 
> Hi Wim,
> 
> unfortunately that only works if the driver is instantiated as platform driver,
> PCI driver, or similar, where a parent device exists. Some drivers are, however,
> instantiated directly from the init function (the BookE driver is an example).
> What is the recommended action in this case ? Convert it to a platform driver ?

If you don't have a bus related driver (like a pci-driver) then indeed it's a
conversion to a platform driver.

Kind regards,
Wim.


  reply	other threads:[~2013-05-30 21:54 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-17 21:19 Don Zickus
2013-04-17 21:33 ` Guenter Roeck
2013-04-17 21:49 ` Eric W. Biederman
2013-04-18  3:03   ` Guenter Roeck
2013-04-18 13:00   ` Don Zickus
2013-04-18 13:49     ` Guenter Roeck
2013-04-18 13:52       ` Don Zickus
2013-04-18 14:54         ` Guenter Roeck
2013-04-24 14:42           ` Don Zickus
2013-04-24 15:21             ` Guenter Roeck
2013-05-27 19:16               ` Wim Van Sebroeck
2013-05-28  1:10                 ` Guenter Roeck
2013-05-30 20:37                   ` Wim Van Sebroeck
2013-05-28 15:34                 ` Guenter Roeck
2013-05-30 21:54                   ` Wim Van Sebroeck [this message]
2013-04-18 16:35 ` Eric W. Biederman
2013-04-18 17:44   ` Don Zickus
2013-04-18 18:09     ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130530215414.GK14258@spo001.leaseweb.com \
    --to=wim@iguana.be \
    --cc=dyoung@redhat.com \
    --cc=dzickus@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®