* Regression introduced by commit "lib/bitmap.c: speed up bitmap_find_free_region"
@ 2013-05-31 6:45 Sachin Kamat
2013-05-31 19:05 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Sachin Kamat @ 2013-05-31 6:45 UTC (permalink / raw)
To: LKML
Cc: Andrew Morton, chanho.min, Kamil Debski, Sylwester Nawrocki,
Arun Kumar K
Hi,
While testing MFC decoder on Exynos machines, I encountered some
memory allocation errors due to failure of dma_alloc_coherent().
File: drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Line: 38.
Git bisect pointed me to the following commit as the first bad commit
(linux-next tree of 20130531):
commit 3d5272d9b289cd0930b2ea9984406d757a72f4dd
Author: Chanho Min <chanho.min@lge.com>
Date: Thu May 23 10:37:28 2013 +1000
lib/bitmap.c: speed up bitmap_find_free_region
Reverting this (and the commit 197e1cf7
("ib-bitmapc-speed-up-bitmap_find_free_region-fix") ) fixes this
issue.
Looks like some regression has been introduced by the above patch?
---
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Regression introduced by commit "lib/bitmap.c: speed up bitmap_find_free_region"
2013-05-31 6:45 Regression introduced by commit "lib/bitmap.c: speed up bitmap_find_free_region" Sachin Kamat
@ 2013-05-31 19:05 ` Andrew Morton
2013-06-03 6:31 ` Stephen Rothwell
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2013-05-31 19:05 UTC (permalink / raw)
To: Sachin Kamat
Cc: LKML, chanho.min, Kamil Debski, Sylwester Nawrocki, Arun Kumar K,
Stephen Rothwell
On Fri, 31 May 2013 12:15:10 +0530 Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Hi,
>
> While testing MFC decoder on Exynos machines, I encountered some
> memory allocation errors due to failure of dma_alloc_coherent().
> File: drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Line: 38.
>
> Git bisect pointed me to the following commit as the first bad commit
> (linux-next tree of 20130531):
>
> commit 3d5272d9b289cd0930b2ea9984406d757a72f4dd
> Author: Chanho Min <chanho.min@lge.com>
> Date: Thu May 23 10:37:28 2013 +1000
> lib/bitmap.c: speed up bitmap_find_free_region
>
> Reverting this (and the commit 197e1cf7
> ("ib-bitmapc-speed-up-bitmap_find_free_region-fix") ) fixes this
> issue.
>
> Looks like some regression has been introduced by the above patch?
Thanks. I dropped the patches for now, to minimise linux-next
breakage. Hopefully we'll be able to identify and fix this at a later
time.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Regression introduced by commit "lib/bitmap.c: speed up bitmap_find_free_region"
2013-05-31 19:05 ` Andrew Morton
@ 2013-06-03 6:31 ` Stephen Rothwell
0 siblings, 0 replies; 3+ messages in thread
From: Stephen Rothwell @ 2013-06-03 6:31 UTC (permalink / raw)
To: Andrew Morton
Cc: Sachin Kamat, LKML, chanho.min, Kamil Debski, Sylwester Nawrocki,
Arun Kumar K
[-- Attachment #1: Type: text/plain, Size: 1231 bytes --]
Hi Andrew,
On Fri, 31 May 2013 12:05:42 -0700 Andrew Morton <akpm@linux-foundation.org> wrote:
>
> On Fri, 31 May 2013 12:15:10 +0530 Sachin Kamat <sachin.kamat@linaro.org> wrote:
>
> > While testing MFC decoder on Exynos machines, I encountered some
> > memory allocation errors due to failure of dma_alloc_coherent().
> > File: drivers/media/platform/s5p-mfc/s5p_mfc_ctrl.c Line: 38.
> >
> > Git bisect pointed me to the following commit as the first bad commit
> > (linux-next tree of 20130531):
> >
> > commit 3d5272d9b289cd0930b2ea9984406d757a72f4dd
> > Author: Chanho Min <chanho.min@lge.com>
> > Date: Thu May 23 10:37:28 2013 +1000
> > lib/bitmap.c: speed up bitmap_find_free_region
> >
> > Reverting this (and the commit 197e1cf7
> > ("ib-bitmapc-speed-up-bitmap_find_free_region-fix") ) fixes this
> > issue.
> >
> > Looks like some regression has been introduced by the above patch?
>
> Thanks. I dropped the patches for now, to minimise linux-next
> breakage. Hopefully we'll be able to identify and fix this at a later
> time.
I removed those 2 patches from the akpm tree in linux-next today as well.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
[-- Attachment #2: Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-06-03 6:32 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-05-31 6:45 Regression introduced by commit "lib/bitmap.c: speed up bitmap_find_free_region" Sachin Kamat
2013-05-31 19:05 ` Andrew Morton
2013-06-03 6:31 ` Stephen Rothwell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®