[PATCH 0/2] staging/asus_oled fixed style issues

[PATCH 0/2] staging/asus_oled fixed style issues

[Matthias Schid]

fixed alignment issue and a linebreak issue reported 
by checkpatch.pl in asus_oled

Matthias Schid (2):
  staging/asus_oled fixed alignment in defines
  staging/asus_oled fixed linebreak style issue

 drivers/staging/asus_oled/asus_oled.c |    9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

-- 
1.7.10.4

[PATCH 1/2] staging/asus_oled fixed alignment in defines

[Matthias Schid]

replaced spaces in incorrect alignment in defines with tabs

Signed-off-by: Matthias Schid <aircrach115@gmail.com>
Signed-off-by: Stefan Huber <steffhip@googlemail.com>
Signed-off-by: Simon Puels <simon.puels@gmail.com>
---
 drivers/staging/asus_oled/asus_oled.c |    6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 4598a2f..173fb9a 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -50,9 +50,9 @@
 #define ASUS_OLED_DISP_HEIGHT		32
 #define ASUS_OLED_PACKET_BUF_SIZE	256
 
-#define USB_VENDOR_ID_ASUS      0x0b05
-#define USB_DEVICE_ID_ASUS_LCM      0x1726
-#define USB_DEVICE_ID_ASUS_LCM2     0x175b
+#define USB_VENDOR_ID_ASUS		0x0b05
+#define USB_DEVICE_ID_ASUS_LCM		0x1726
+#define USB_DEVICE_ID_ASUS_LCM2		0x175b
 
 MODULE_AUTHOR("Jakub Schmidtke, sjakub@gmail.com");
 MODULE_DESCRIPTION("Asus OLED Driver");
-- 
1.7.10.4

[PATCH 2/2] staging/asus_oled fixed linebreak style issue

[Matthias Schid]

fixed a linebreak within an error message string coding style
issue reported by checkpatch.pl

Signed-off-by: Matthias Schid <aircrach115@gmail.com>
Signed-off-by: Stefan Huber <steffhip@googlemail.com>
Signed-off-by: Simon Puels <simon.puels@gmail.com>
---
 drivers/staging/asus_oled/asus_oled.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 173fb9a..a7cd65a 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -383,8 +383,7 @@ static int append_values(struct asus_oled_dev *odev, uint8_t val, size_t count)
 		}
 
 		if (i >= odev->buf_size) {
-			dev_err(odev->dev, "Buffer overflow! Report a bug:"
-			       "offs: %d >= %d i: %d (x: %d y: %d)\n",
+			dev_err(odev->dev, "Buffer overflow! Report a bug: offs: %d >= %d i: %d (x: %d y: %d)\n",
 			       (int) odev->buf_offs, (int) odev->buf_size,
 			       (int) i, (int) x, (int) y);
 			return -EIO;
-- 
1.7.10.4

Re: [PATCH 2/2] staging/asus_oled fixed linebreak style issue

[Dan Carpenter]

On Wed, Jun 05, 2013 at 12:50:45PM +0200, Matthias Schid wrote:
> fixed a linebreak within an error message string coding style
> issue reported by checkpatch.pl
> 
> Signed-off-by: Matthias Schid <aircrach115@gmail.com>
> Signed-off-by: Stefan Huber <steffhip@googlemail.com>
> Signed-off-by: Simon Puels <simon.puels@gmail.com>
> ---
>  drivers/staging/asus_oled/asus_oled.c |    3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
> index 173fb9a..a7cd65a 100644
> --- a/drivers/staging/asus_oled/asus_oled.c
> +++ b/drivers/staging/asus_oled/asus_oled.c
> @@ -383,8 +383,7 @@ static int append_values(struct asus_oled_dev *odev, uint8_t val, size_t count)
>  		}
>  
>  		if (i >= odev->buf_size) {
> -			dev_err(odev->dev, "Buffer overflow! Report a bug:"
> -			       "offs: %d >= %d i: %d (x: %d y: %d)\n",
> +			dev_err(odev->dev, "Buffer overflow! Report a bug: offs: %d >= %d i: %d (x: %d y: %d)\n",
>  			       (int) odev->buf_offs, (int) odev->buf_size,
>  			       (int) i, (int) x, (int) y);

This could be improved:

			dev_err(odev->dev,
				"Buffer overflow! Report a bug: offs: %zu >= %d i: %zu (x: %zu y: %zu)\n",
			     	odev->buf_offs, odev->buf_size, i, x, y);

Printk fromats are documented in Documentation/printk-formats.txt.

regards,
dan carpenter

[PATCH 2/2] staging/asus_oled fixed linebreak and printk issue

[Matthias Schid]

fixed a linebreak within an error message string coding style
issue reported by checkpatch.pl and dev_err format parameters

Signed-off-by: Matthias Schid <aircrach115@gmail.com>
Signed-off-by: Stefan Huber <steffhip@googlemail.com>
Signed-off-by: Simon Puels <simon.puels@gmail.com>
---
 drivers/staging/asus_oled/asus_oled.c |    6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/staging/asus_oled/asus_oled.c b/drivers/staging/asus_oled/asus_oled.c
index 173fb9a..9fe13d0 100644
--- a/drivers/staging/asus_oled/asus_oled.c
+++ b/drivers/staging/asus_oled/asus_oled.c
@@ -383,10 +383,8 @@ static int append_values(struct asus_oled_dev *odev, uint8_t val, size_t count)
 		}
 
 		if (i >= odev->buf_size) {
-			dev_err(odev->dev, "Buffer overflow! Report a bug:"
-			       "offs: %d >= %d i: %d (x: %d y: %d)\n",
-			       (int) odev->buf_offs, (int) odev->buf_size,
-			       (int) i, (int) x, (int) y);
+			dev_err(odev->dev, "Buffer overflow! Report a bug: offs: %zu >= %zu i: %zu (x: %zu y: %zu)\n",
+			       odev->buf_offs, odev->buf_size, i, x, y);
 			return -EIO;
 		}
 
-- 
1.7.10.4