From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Jonas Jensen <jonas.jensen@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, arm@kernel.org, tglx@linutronix.de
Subject: Re: [PATCH] ARM: irqchip: add support for MOXA ART SoCs
Date: Tue, 18 Jun 2013 11:35:35 +0100 [thread overview]
Message-ID: <20130618103534.GW2718@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1371549584-7169-1-git-send-email-jonas.jensen@gmail.com>
On Tue, Jun 18, 2013 at 11:59:44AM +0200, Jonas Jensen wrote:
> +void moxart_irq_ack(struct irq_data *irqd)
> +{
> + unsigned int irq = irqd_to_hwirq(irqd);
> +
> + writel(1 << irq, IRQ_CLEAR(moxart_irq_base));
> +}
> +
> +static void moxart_irq_mask(struct irq_data *irqd)
> +{
> + unsigned int irq = irqd_to_hwirq(irqd);
> + unsigned int mask;
> +
> + mask = readl(IRQ_MASK(moxart_irq_base));
> + mask &= ~(1 << irq);
> + writel(mask, IRQ_MASK(moxart_irq_base));
> +}
> +
> +static void moxart_irq_unmask(struct irq_data *irqd)
> +{
> + unsigned int irq = irqd_to_hwirq(irqd);
> + unsigned int mask;
> +
> + mask = readl(IRQ_MASK(moxart_irq_base));
> + mask |= (1 << irq);
> + writel(mask, IRQ_MASK(moxart_irq_base));
> +}
Is there a reason this isn't using the irq_chip_generic stuff which would
eliminate all the above?
next prev parent reply other threads:[~2013-06-18 10:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-18 9:59 Jonas Jensen
2013-06-18 10:35 ` Russell King - ARM Linux [this message]
2013-06-18 12:54 ` Arnd Bergmann
2013-06-18 13:41 ` Thomas Petazzoni
2013-06-20 8:58 ` [PATCH v2] " Jonas Jensen
2013-06-20 10:17 ` Arnd Bergmann
2013-06-24 13:18 ` Grant Likely
2013-06-27 13:29 ` [PATCH v3] ARM: " Jonas Jensen
2013-06-27 17:49 ` Uwe Kleine-König
2013-07-01 14:34 ` [PATCH v4] " Jonas Jensen
2013-07-04 12:38 ` [PATCH v5] " Jonas Jensen
2013-07-05 9:49 ` [tip:irq/urgent] irqchip: Add " tip-bot for Jonas Jensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130618103534.GW2718@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=arm@kernel.org \
--cc=jonas.jensen@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome