* [PATCH 0/4] usb: ohci-ep93xx: do a bit of house cleaning
@ 2013-06-29 0:26 H Hartley Sweeten
2013-07-01 21:18 ` Alan Stern
0 siblings, 1 reply; 2+ messages in thread
From: H Hartley Sweeten @ 2013-06-29 0:26 UTC (permalink / raw)
To: Linux Kernel; +Cc: stern, kernel, gregkh, hsweeten
Tidy up this driver a bit.
H Hartley Sweeten (4):
usb: ohci-ep93xx: use devm_ioremap_resource()
usb: ohci-ep93xx: use platform_get_irq()
usb: ohci-ep93xx: use devm_clk_get()
usb: ohci-ep93xx: tidy up ohci_hcd_ep93xx_drv_probe()
drivers/usb/host/ohci-ep93xx.c | 60 ++++++++++++++++--------------------------
1 file changed, 23 insertions(+), 37 deletions(-)
--
1.8.1.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 0/4] usb: ohci-ep93xx: do a bit of house cleaning
2013-06-29 0:26 [PATCH 0/4] usb: ohci-ep93xx: do a bit of house cleaning H Hartley Sweeten
@ 2013-07-01 21:18 ` Alan Stern
0 siblings, 0 replies; 2+ messages in thread
From: Alan Stern @ 2013-07-01 21:18 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, kernel, gregkh, hsweeten
On Fri, 28 Jun 2013, H Hartley Sweeten wrote:
> Tidy up this driver a bit.
>
> H Hartley Sweeten (4):
> usb: ohci-ep93xx: use devm_ioremap_resource()
> usb: ohci-ep93xx: use platform_get_irq()
> usb: ohci-ep93xx: use devm_clk_get()
> usb: ohci-ep93xx: tidy up ohci_hcd_ep93xx_drv_probe()
Patches 1 - 3 look fine; you can add my Acked-by: to them.
For patch 4, we really should have a little more tidying up. The
ohci_hcd_ep93xx_drv_probe() routine should be merged with
usb_hcd_ep93xx_probe(); there's no reason for them to be separate.
Likewise for ohci_hcd_ep93xx_drv_remove() and usb_hcd_ep93xx_remove().
Also, if you feel up to it, I think it would make sense to eliminate
the ep93xx_start_hc() and ep93xx_stop_hc() routines and simply call
clk_enable() and clk_disable() directly. The extra level of
redirection does not add any clarity.
Alan Stern
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-01 21:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-06-29 0:26 [PATCH 0/4] usb: ohci-ep93xx: do a bit of house cleaning H Hartley Sweeten
2013-07-01 21:18 ` Alan Stern
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®