mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jason Cooper <jason@lakedaemon.net>
To: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Cc: Arnaud Ebalard <arno@natisbad.org>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	Andrew Lunn <andrew@lunn.ch>,
	Russell King <linux@arm.linux.org.uk>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	Gregory CLEMENT <gregory.clement@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v6 5/7] ARM: kirkwood: remove redundant DT board files
Date: Wed, 3 Jul 2013 10:33:04 -0400	[thread overview]
Message-ID: <20130703143304.GI17110@titan.lakedaemon.net> (raw)
In-Reply-To: <51D40BA3.6000603@gmail.com>

On Wed, Jul 03, 2013 at 01:31:47PM +0200, Sebastian Hesselbarth wrote:
> On 07/03/13 01:09, Arnaud Ebalard wrote:
> >Hi Sebastian,
> >
> >Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com> writes:
> >
> >>With DT support for mv643xx_eth board specific init for some boards now
> >>is unneccessary. Remove those board files, Kconfig entries, and
> >>corresponding entries in kirkwood_defconfig.
> >
> >Applying above your set an old quilt cleaning patch Jason asked at some
> >point, it became empty except for arch/arm/mach_kirkwood/common.h in
> >which some declarations were left behind. If this is correct, can you
> >just merge the hunks below in your 5/7 in next round?
> >
> >AFAICT, only dnskw_init() remains, which matches the list of board-*.c
> >files in arch/arm/mach_kirkwood/ (i.e. board-dt.c and board-dnskw.c).
> 
> While updating the patch with yours, I stumbled upon MACH_TS219_DT that
> also remains because it includes tsx1x-common.c.
> 
> I cannot recall if Jason or Andrew said something about removing it..

board-ts219.c can be removed as well.  It needed a check for running on
the 6282 variant in order to set the phy address properly.  This can now
be handled in kirkwood-ts219-628[12].dts.

thx,

Jason.

  reply	other threads:[~2013-07-03 14:33 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-02 11:00 [PATCH v6 0/7] ARM: mvebu: switch to DT probed mv643xx_eth Sebastian Hesselbarth
2013-07-02 11:00 ` [PATCH v6 1/7] ARM: dove: add gigabit ethernet and mvmdio device tree nodes Sebastian Hesselbarth
2013-07-02 11:00 ` [PATCH v6 2/7] ARM: kirkwood: " Sebastian Hesselbarth
2013-07-07 20:34   ` [PATCH v7 " Sebastian Hesselbarth
2013-07-02 11:00 ` [PATCH v6 3/7] ARM: orion5x: " Sebastian Hesselbarth
2013-07-02 11:00 ` [PATCH v6 4/7] ARM: dove: remove legacy mv643xx_eth setup Sebastian Hesselbarth
2013-07-02 11:00 ` [PATCH v6 5/7] ARM: kirkwood: remove redundant DT board files Sebastian Hesselbarth
2013-07-02 23:09   ` Arnaud Ebalard
2013-07-02 23:29     ` Sebastian Hesselbarth
2013-07-03 11:31     ` Sebastian Hesselbarth
2013-07-03 14:33       ` Jason Cooper [this message]
2013-07-03 14:40       ` Jason Cooper
2013-07-03 16:57   ` [PATCH v7 " Sebastian Hesselbarth
2013-07-02 11:00 ` [PATCH v6 6/7] ARM: kirkwood: remove legacy clk alias for mv643xx_eth Sebastian Hesselbarth
2013-07-02 11:00 ` [PATCH v6 7/7] ARM: orion5x: remove legacy mv643xx_eth board setup Sebastian Hesselbarth
2013-07-25 17:11 ` [PATCH v6 0/7] ARM: mvebu: switch to DT probed mv643xx_eth Jason Cooper

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130703143304.GI17110@titan.lakedaemon.net \
    --to=jason@lakedaemon.net \
    --cc=andrew@lunn.ch \
    --cc=arno@natisbad.org \
    --cc=gregory.clement@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=netdev@vger.kernel.org \
    --cc=sebastian.hesselbarth@gmail.com \
    --cc=thomas.petazzoni@free-electrons.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®