* [PATCH] watchdog: softdog: remove replaceable ping operation
@ 2013-03-26 7:26 Kim, Milo
2013-07-09 19:00 ` Wim Van Sebroeck
0 siblings, 1 reply; 2+ messages in thread
From: Kim, Milo @ 2013-03-26 7:26 UTC (permalink / raw)
To: wim; +Cc: linux-watchdog, linux-kernel
In watchdog_ping(), 'start' is called automatically when 'ping' function call
is not configured.
Softdog driver has same handling in both cases - start and ping, so 'ping' OPS
can be removed.
Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
---
drivers/watchdog/softdog.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/watchdog/softdog.c b/drivers/watchdog/softdog.c
index fe83beb..b68b1e5 100644
--- a/drivers/watchdog/softdog.c
+++ b/drivers/watchdog/softdog.c
@@ -152,7 +152,6 @@ static struct watchdog_ops softdog_ops = {
.owner = THIS_MODULE,
.start = softdog_ping,
.stop = softdog_stop,
- .ping = softdog_ping,
.set_timeout = softdog_set_timeout,
};
--
1.7.9.5
Best Regards,
Milo
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] watchdog: softdog: remove replaceable ping operation
2013-03-26 7:26 [PATCH] watchdog: softdog: remove replaceable ping operation Kim, Milo
@ 2013-07-09 19:00 ` Wim Van Sebroeck
0 siblings, 0 replies; 2+ messages in thread
From: Wim Van Sebroeck @ 2013-07-09 19:00 UTC (permalink / raw)
To: Kim, Milo; +Cc: linux-watchdog, linux-kernel
Hi Milo,
> In watchdog_ping(), 'start' is called automatically when 'ping' function call
> is not configured.
> Softdog driver has same handling in both cases - start and ping, so 'ping' OPS
> can be removed.
>
> Signed-off-by: Milo(Woogyom) Kim <milo.kim@ti.com>
> ---
> drivers/watchdog/softdog.c | 1 -
> 1 file changed, 1 deletion(-)
Patch added to linux-watchdog-next.
Kind regards,
Wim.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-09 19:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-26 7:26 [PATCH] watchdog: softdog: remove replaceable ping operation Kim, Milo
2013-07-09 19:00 ` Wim Van Sebroeck
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®