* [PATCH] ASoC: imx-sgtl5000: fix error return code in imx_sgtl5000_probe()
@ 2013-07-16 12:05 Wei Yongjun
2013-07-16 12:27 ` Shawn Guo
2013-07-16 13:51 ` Mark Brown
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2013-07-16 12:05 UTC (permalink / raw)
To: lgirdwood, broonie, perex, tiwai, grant.likely, rob.herring,
shawn.guo, fabio.estevam, wfp5p, LW
Cc: yongjun_wei, alsa-devel, devicetree-discuss, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
sound/soc/fsl/imx-sgtl5000.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/sound/soc/fsl/imx-sgtl5000.c b/sound/soc/fsl/imx-sgtl5000.c
index 7a8bc12..25f310d 100644
--- a/sound/soc/fsl/imx-sgtl5000.c
+++ b/sound/soc/fsl/imx-sgtl5000.c
@@ -129,8 +129,10 @@ static int imx_sgtl5000_probe(struct platform_device *pdev)
}
data->codec_clk = devm_clk_get(&codec_dev->dev, NULL);
- if (IS_ERR(data->codec_clk))
+ if (IS_ERR(data->codec_clk)) {
+ ret = PTR_ERR(data->codec_clk);
goto fail;
+ }
data->clk_frequency = clk_get_rate(data->codec_clk);
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: imx-sgtl5000: fix error return code in imx_sgtl5000_probe()
2013-07-16 12:05 [PATCH] ASoC: imx-sgtl5000: fix error return code in imx_sgtl5000_probe() Wei Yongjun
@ 2013-07-16 12:27 ` Shawn Guo
2013-07-16 13:51 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Shawn Guo @ 2013-07-16 12:27 UTC (permalink / raw)
To: Wei Yongjun
Cc: lgirdwood, broonie, perex, tiwai, grant.likely, rob.herring,
fabio.estevam, wfp5p, LW, yongjun_wei, alsa-devel,
devicetree-discuss, linux-kernel
On Tue, Jul 16, 2013 at 08:05:07PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Shawn Guo <shawn.guo@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ASoC: imx-sgtl5000: fix error return code in imx_sgtl5000_probe()
2013-07-16 12:05 [PATCH] ASoC: imx-sgtl5000: fix error return code in imx_sgtl5000_probe() Wei Yongjun
2013-07-16 12:27 ` Shawn Guo
@ 2013-07-16 13:51 ` Mark Brown
1 sibling, 0 replies; 3+ messages in thread
From: Mark Brown @ 2013-07-16 13:51 UTC (permalink / raw)
To: Wei Yongjun
Cc: lgirdwood, perex, tiwai, grant.likely, rob.herring, shawn.guo,
fabio.estevam, wfp5p, LW, yongjun_wei, alsa-devel,
devicetree-discuss, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 260 bytes --]
On Tue, Jul 16, 2013 at 08:05:07PM +0800, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code from the error handling
> case instead of 0, as done elsewhere in this function.
Applied, thanks.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-07-16 13:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-16 12:05 [PATCH] ASoC: imx-sgtl5000: fix error return code in imx_sgtl5000_probe() Wei Yongjun
2013-07-16 12:27 ` Shawn Guo
2013-07-16 13:51 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®