From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Cc: Julien Grall <julien.grall@linaro.org>,
Ian Campbell <Ian.Campbell@citrix.com>,
patches@linaro.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled
Date: Wed, 17 Jul 2013 16:11:48 +0100 [thread overview]
Message-ID: <20130717151148.GM24642@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <alpine.DEB.2.02.1307171420350.8258@kaball.uk.xensource.com>
On Wed, Jul 17, 2013 at 02:25:38PM +0100, Stefano Stabellini wrote:
> On Mon, 15 Jul 2013, Julien Grall wrote:
> > Even if uncompress debug is disabled, some board will continue to print
> > information during uncompress step.
>
> Are you talking about DEBUG_UNCOMPRESS?
> Should I read the sentence as "even if DEBUG_UNCOMPRESS is not selected,
> some board will continue to print information during the uncompress step"?
>
> Isn't this a bug in the platform specific code that should be fixed anyway?
Hang on, let's be clear what's going on here.
1. The normal output from the decompressor is *not* debugging. By that
I mean the "Uncompressing kernel... done" message. That is part of
user output.
2. In non-multiplatform environments, the decompressor will normally use
the putc/flush functions found in arch/arm/mach-*/include/mach/uncompress.h
to implement its output, irrespective of the DEBUG_UNCOMPRESS setting.
(An interesting point is that DEBUG_UNCOMPRESS really should depend on
MULTIPLATFORM so that this point is explicit - the option requires
MULTIPLATFORM to be set.)
3. DEBUG_UNCOMPRESS allows the functions which we've implemented for LL
debug to be re-used for decompressor output.
4. When DEBUG_UNCOMPRESS is not set in a multiplatform kernel, the
decompressors putc() and flush() functions are stubbed out.
So, it's quite right that you get output from the decompressor even when
DEBUG_UNCOMPRESS is not set. There's no problem with that.
next prev parent reply other threads:[~2013-07-17 15:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-15 14:15 Julien Grall
2013-07-17 13:25 ` Stefano Stabellini
2013-07-17 15:11 ` Russell King - ARM Linux [this message]
2013-07-17 15:18 ` Russell King - ARM Linux
2013-07-17 16:48 ` Stefano Stabellini
2013-07-18 16:43 ` Julien Grall
2013-07-18 16:50 ` Russell King - ARM Linux
2013-07-18 17:24 ` [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabledo Stefano Stabellini
2013-07-20 16:50 ` Arnd Bergmann
2013-07-18 16:15 ` [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled Julien Grall
2013-07-18 16:23 ` Russell King - ARM Linux
2013-07-19 8:32 ` Ian Campbell
2013-07-19 9:52 ` Stefano Stabellini
2013-07-19 10:00 ` Ian Campbell
2013-07-19 10:06 ` Stefano Stabellini
2013-07-19 10:12 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130717151148.GM24642@n2100.arm.linux.org.uk \
--to=linux@arm.linux.org.uk \
--cc=Ian.Campbell@citrix.com \
--cc=arnd@arndb.de \
--cc=julien.grall@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=patches@linaro.org \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®