mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Julien Grall <julien.grall@linaro.org>
Cc: Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Patch Tracking <patches@linaro.org>,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
	Olof Johansson <olof@lixom.net>
Subject: Re: [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled
Date: Thu, 18 Jul 2013 17:23:44 +0100	[thread overview]
Message-ID: <20130718162344.GZ24642@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <CAPnVf8yH7PBOSSC57qJv+pWmsinRUxGr81QUPH9GoOkKw2oo3Q@mail.gmail.com>

On Thu, Jul 18, 2013 at 05:15:21PM +0100, Julien Grall wrote:
> On 17 July 2013 14:25, Stefano Stabellini
> <stefano.stabellini@eu.citrix.com> wrote:
> > On Mon, 15 Jul 2013, Julien Grall wrote:
> >> Even if uncompress debug is disabled, some board will continue to print
> >> information during uncompress step.
> >
> > Are you talking about DEBUG_UNCOMPRESS?
> > Should I read the sentence as "even if DEBUG_UNCOMPRESS is not selected,
> > some board will continue to print information during the uncompress step"?
> 
> Yes. On the arndale, uncompress log are directly output on UART-2.
> This is annoying because  Xen doesn't expose the UART to dom0.

The DEBUG_UNCOMPRESS option is not about whether the decompressor produces
output or not.  It is about the implementation of that output.

* With non-multiplatform kernels, the output is sent to whatever functions
  are found in arch/arm/*/include/mach/uncompress.h.

* With multiplatform kernels with DEBUG_UNCOMPRESS set, the output is sent
  using the kernel's LL debug functions.  (hence it's name - it's saying
  that it uses the debug macros.)

* With multiplatform kernels without DEBUG_UNCOMPRESS set, there is no
  way to know where to send the *normal* decompressor output, so we have
  decided that in this case and this case only, it shall be silent.

The final thing to remember is... the normal output from the decompressor
is *NOT* debug output.  It's informational or error output.

Everything here is working as intended.

  reply	other threads:[~2013-07-18 16:24 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-15 14:15 Julien Grall
2013-07-17 13:25 ` Stefano Stabellini
2013-07-17 15:11   ` Russell King - ARM Linux
2013-07-17 15:18     ` Russell King - ARM Linux
2013-07-17 16:48       ` Stefano Stabellini
2013-07-18 16:43     ` Julien Grall
2013-07-18 16:50       ` Russell King - ARM Linux
2013-07-18 17:24         ` [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabledo Stefano Stabellini
2013-07-20 16:50           ` Arnd Bergmann
2013-07-18 16:15   ` [PATCH] arm: choose debug/uncompress.h include when uncompress debug is disabled Julien Grall
2013-07-18 16:23     ` Russell King - ARM Linux [this message]
2013-07-19  8:32     ` Ian Campbell
2013-07-19  9:52       ` Stefano Stabellini
2013-07-19 10:00         ` Ian Campbell
2013-07-19 10:06           ` Stefano Stabellini
2013-07-19 10:12             ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130718162344.GZ24642@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=Ian.Campbell@citrix.com \
    --cc=arnd@arndb.de \
    --cc=julien.grall@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=olof@lixom.net \
    --cc=patches@linaro.org \
    --cc=stefano.stabellini@eu.citrix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®