infiniband build warning

infiniband build warning

[Michel Lespinasse]

Hi,

I am seeing build warnings in drivers/infiniband/core/cma.c starting with v3.11-rc1. These can be reproduced with gcc 4.6.3.

Would you consider applying the following fix ?
(The compiler warning seems benign as I could easily convince myself that the variable won't be used uninitialized, but I'd like to get rid of the compiler warning anyway).

--------------------------------- 8< ------------------------------------
infiniband: fix maybe-uninitialized warning in rdma_resolve_addr()

This fixes the following warning:

drivers/infiniband/core/cma.c: In function 'rdma_resolve_addr':
drivers/infiniband/core/cma.c:465:23: error: 'port' may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/infiniband/core/cma.c:426:5: note: 'port' was declared here

The warning looks benign: port is only used after checking that
cma_dev is not NULL, and all assignments to cma_dev also set port.

diff --git a/drivers/infiniband/core/cma.c b/drivers/infiniband/core/cma.c
index f1c279fabe64..7b2e38ad1243 100644
--- a/drivers/infiniband/core/cma.c
+++ b/drivers/infiniband/core/cma.c
@@ -423,7 +423,7 @@ static int cma_resolve_ib_dev(struct rdma_id_private *id_priv)
 	struct sockaddr_ib *addr;
 	union ib_gid gid, sgid, *dgid;
 	u16 pkey, index;
-	u8 port, p;
+	u8 port = 0, p;
 	int i;
 
 	cma_dev = NULL;

-- 
Michel "Walken" Lespinasse
A program is never fully debugged until the last user dies.

RE: infiniband build warning

[Hefty, Sean]

> I am seeing build warnings in drivers/infiniband/core/cma.c starting with
> v3.11-rc1. These can be reproduced with gcc 4.6.3.
> 
> Would you consider applying the following fix ?

A patch to fix this was submitted to the linux-rdma list last week.	  Thanks.

- Sean

Re: infiniband build warning

[Or Gerlitz]

On Mon, Jul 22, 2013 at 8:40 AM, Hefty, Sean <sean.hefty@intel.com> wrote:
>> I am seeing build warnings in drivers/infiniband/core/cma.c starting with
>> v3.11-rc1. These can be reproduced with gcc 4.6.3.
>> Would you consider applying the following fix ?

> A patch to fix this was submitted to the linux-rdma list last week.

Hi Roland,

There is a nice set of patches (IPoIB virtualization fixes, mlx5
fixes, iser patches to cope with Connect-IB no FMR, etc, etc) posted
to linux-rdma little before && after 3.11-rc1 was out, and we are @
rc2 now. I think we need to get them upstreamed around this time such
that its early enough in the cycle, makes sense?

Or.