Re: [PATCH V8 13/15] perf tools: expand perf_event__synthesize_sample()

[Jiri Olsa <jolsa@redhat.com>]

On Thu, Jul 18, 2013 at 01:42:55PM +0300, Adrian Hunter wrote:

SNIP

> @@ -1349,11 +1349,12 @@ int perf_evsel__parse_sample(struct perf_evsel *evsel, union perf_event *event,
>  }
>  
>  int perf_event__synthesize_sample(union perf_event *event, u64 type,
> +				  u64 sample_regs_user,
>  				  const struct perf_sample *sample,
>  				  bool swapped)
>  {
>  	u64 *array;
> -
> +	size_t sz;
>  	/*
>  	 * used for cross-endian analysis. See git commit 65014ab3
>  	 * for why this goofiness is needed.
> @@ -1426,6 +1427,73 @@ int perf_event__synthesize_sample(union perf_event *event, u64 type,
>  		array++;
>  	}
>  
> +	if (type & PERF_SAMPLE_READ) {
> +		fprintf(stderr, "PERF_SAMPLE_READ is unsupported for now\n");
> +		return -1;
> +	}
> +
> +	if (type & PERF_SAMPLE_CALLCHAIN) {
> +		sz = (sample->callchain->nr + 1) * sizeof(u64);
> +		memcpy(array, sample->callchain, sz);
> +		array = (void *)array + sz;
> +	}
> +
> +	if (type & PERF_SAMPLE_RAW) {
> +		u.val32[0] = sample->raw_size;
> +		if (WARN_ONCE(swapped,
> +			      "Endianness of raw data not corrected!\n")) {
> +			/*
> +			 * Inverse of what is done in perf_evsel__parse_sample
> +			 */
> +			u.val32[0] = bswap_32(u.val32[0]);
> +			u.val32[1] = bswap_32(u.val32[1]);
> +			u.val64 = bswap_64(u.val64);
> +		}
> +		*array = u.val64;
> +		array = (void *)array + sizeof(u32);
> +
> +		memcpy(array, sample->raw_data, sample->raw_size);
> +		array = (void *)array + sample->raw_size;
> +	}
> +
> +	if (type & PERF_SAMPLE_BRANCH_STACK) {
> +		sz = sample->branch_stack->nr * sizeof(struct branch_entry);
> +		sz += sizeof(u64);
> +		memcpy(array, sample->branch_stack, sz);
> +		array = (void *)array + sz;
> +	}
> +
> +	if (type & PERF_SAMPLE_REGS_USER) {
> +		if (sample->user_regs.regs && sample_regs_user) {
> +			*array++ = sample_regs_user;

it's 'enum perf_sample_regs_abi' value that goes here ^^^

I guess for now it could be hardcoded like:

#if defined(__x86_64__)
abi = PERF_SAMPLE_REGS_ABI_64
#else
#if defined(__i386__)
abi = PERF_SAMPLE_REGS_ABI_64
#endif
WARN()
#endif


jirka