From: Jiri Olsa <jolsa@redhat.com>
To: Adrian Hunter <adrian.hunter@intel.com>
Cc: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>,
linux-kernel@vger.kernel.org, David Ahern <dsahern@gmail.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Mike Galbraith <efault@gmx.de>, Namhyung Kim <namhyung@gmail.com>,
Paul Mackerras <paulus@samba.org>,
Peter Zijlstra <peterz@infradead.org>,
Stephane Eranian <eranian@google.com>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH V8 13/15] perf tools: expand perf_event__synthesize_sample()
Date: Wed, 24 Jul 2013 15:15:27 +0200 [thread overview]
Message-ID: <20130724131526.GD4203@krava.brq.redhat.com> (raw)
In-Reply-To: <51EFD368.2080901@intel.com>
On Wed, Jul 24, 2013 at 04:15:20PM +0300, Adrian Hunter wrote:
SNIP
> >> + }
> >> +
> >> + if (type & PERF_SAMPLE_REGS_USER) {
> >> + if (sample->user_regs.regs && sample_regs_user) {
> >> + *array++ = sample_regs_user;
> >
> > it's 'enum perf_sample_regs_abi' value that goes here ^^^
> >
> > I guess for now it could be hardcoded like:
> >
> > #if defined(__x86_64__)
> > abi = PERF_SAMPLE_REGS_ABI_64
> > #else
> > #if defined(__i386__)
> > abi = PERF_SAMPLE_REGS_ABI_64
ugh, PERF_SAMPLE_REGS_ABI_32 ^^^ of course ;-)
> > #endif
> > WARN()
> > #endif
>
> Thanks for reviewing this.
>
> Why isn't it better to leave it as a parameter?
np, you could have it as parameter.. but I guess for now
you'll endup with above code in the upper layer anyway
jirka
next prev parent reply other threads:[~2013-07-24 13:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-18 10:42 [PATCH V8 00/15] perf tools: some fixes and tweaks Adrian Hunter
2013-07-18 10:42 ` [PATCH V8 01/15] perf tools: add debug prints Adrian Hunter
2013-07-18 10:42 ` [PATCH V8 02/15] perf tools: allow non-matching sample types Adrian Hunter
2013-07-18 10:42 ` [PATCH V8 03/15] perf tools: add pid to struct thread Adrian Hunter
2013-07-26 15:56 ` David Ahern
2013-07-18 10:42 ` [PATCH V8 04/15] perf tools: change machine__findnew_thread() to set thread pid Adrian Hunter
2013-07-26 16:02 ` David Ahern
2013-07-28 10:43 ` Adrian Hunter
2013-07-29 22:19 ` David Ahern
2013-07-18 10:42 ` [PATCH V8 05/15] perf tools: tidy up sample parsing overflow checking Adrian Hunter
2013-07-18 10:42 ` [PATCH V8 06/15] perf tools: remove unnecessary callchain validation Adrian Hunter
2013-07-18 10:42 ` [PATCH V8 07/15] perf tools: remove references to struct ip_event Adrian Hunter
2013-07-18 10:42 ` [PATCH V8 08/15] perf tools: move " Adrian Hunter
2013-07-18 10:42 ` [PATCH V8 09/15] perf: Update perf_event_type documentation Adrian Hunter
2013-07-18 10:42 ` [PATCH V8 10/15] perf: make events stream always parsable Adrian Hunter
2013-07-29 9:55 ` Stephane Eranian
2013-07-18 10:42 ` [PATCH V8 11/15] perf tools: move perf_evlist__config() to a new source file Adrian Hunter
2013-07-18 10:42 ` [PATCH V8 12/15] perf tools: add support for PERF_SAMPLE_IDENTFIER Adrian Hunter
2013-07-18 10:42 ` [PATCH V8 13/15] perf tools: expand perf_event__synthesize_sample() Adrian Hunter
2013-07-24 12:50 ` Jiri Olsa
2013-07-24 13:15 ` Adrian Hunter
2013-07-24 13:15 ` Jiri Olsa [this message]
2013-07-18 10:42 ` [PATCH V8 14/15] perf tools: add a function to calculate sample event size Adrian Hunter
2013-07-24 13:01 ` Jiri Olsa
2013-07-18 10:42 ` [PATCH V8 15/15] perf tools: add a sample parsing test Adrian Hunter
2013-07-24 13:12 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130724131526.GD4203@krava.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=acme@ghostprotocols.net \
--cc=adrian.hunter@intel.com \
--cc=dsahern@gmail.com \
--cc=efault@gmx.de \
--cc=eranian@google.com \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung@gmail.com \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome