From: Mark Brown <broonie@kernel.org>
To: "Felipe F. Tonello" <eu@felipetonello.com>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Takashi Iwai <tiwai@suse.de>,
David Henningsson <david.henningsson@canonical.com>,
Wang Xingchao <xingchao.wang@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 1/4] ALSA: Added jack detection kcontrol support
Date: Fri, 26 Jul 2013 19:54:58 +0100 [thread overview]
Message-ID: <20130726185458.GX9858@sirena.org.uk> (raw)
In-Reply-To: <1374863133-6745-2-git-send-email-eu@felipetonello.com>
[-- Attachment #1: Type: text/plain, Size: 691 bytes --]
On Fri, Jul 26, 2013 at 11:25:30AM -0700, Felipe F. Tonello wrote:
> +
> + /* Update ALSA KControl interface */
> + snd_kctl_jack_report((struct snd_card *)jack->kctl->private_data, jack->kctl, !!status);
This isn't ideal for multi-function jacks like headsets - it will report
a single boolean value for the jack regardless of what's plugged in
meaning userpace can't do things like figure out if a headset or
headphone is present. It's probably OK for any realistic input button
since you're not going to get an input button without other things being
present.
What I'd expect to happen here is that for multi function jacks we
create a control per function if the controls are valid.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-07-26 18:55 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-26 18:25 [PATCH 0/4] ALSA: Implement core jack support for kcontrol Felipe F. Tonello
2013-07-26 18:25 ` [PATCH 1/4] ALSA: Added jack detection kcontrol support Felipe F. Tonello
2013-07-26 18:46 ` Mark Brown
2013-07-26 19:04 ` Felipe Tonello
2013-07-26 18:54 ` Mark Brown [this message]
2013-07-26 19:10 ` Felipe Tonello
2013-07-26 22:48 ` Mark Brown
2013-07-26 23:13 ` Felipe Tonello
2013-07-27 12:25 ` Mark Brown
2013-07-29 12:05 ` Takashi Iwai
2013-08-01 3:49 ` Felipe Ferreri Tonello
2013-08-01 3:48 ` Felipe Ferreri Tonello
2013-08-01 8:24 ` Mark Brown
2013-07-26 18:25 ` [PATCH 2/4] ALSA: HDA: Updating jack implementation according new ALSA Jacks Felipe F. Tonello
2013-07-26 18:25 ` [PATCH 3/4] ALSA: SoC: " Felipe F. Tonello
2013-07-26 18:50 ` Mark Brown
2013-07-26 19:11 ` Felipe Tonello
2013-07-26 18:25 ` [PATCH 4/4] ALSA: oxygen: " Felipe F. Tonello
2013-07-26 18:56 ` Mark Brown
2013-07-26 19:02 ` Felipe Tonello
2013-07-26 22:45 ` Mark Brown
2013-07-26 22:48 ` Felipe Tonello
2013-07-29 12:10 ` Takashi Iwai
2013-08-01 3:51 ` Felipe Ferreri Tonello
2013-07-26 22:45 ` [PATCH v2 0/3] ALSA: Implement core jack support for kcontrol Felipe F. Tonello
2013-07-26 22:45 ` [PATCH v2 1/3] ALSA: Added jack detection kcontrol support Felipe F. Tonello
2013-07-29 14:19 ` Takashi Iwai
2013-08-01 3:52 ` Felipe Ferreri Tonello
2013-07-26 22:45 ` [PATCH v2 2/3] ALSA: pci: HDA/oxygen: Updating jack implementation according new ALSA Jacks Felipe F. Tonello
2013-07-26 22:45 ` [PATCH v2 3/3] ALSA: SoC: " Felipe F. Tonello
2013-07-29 15:03 ` Stephen Warren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130726185458.GX9858@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=david.henningsson@canonical.com \
--cc=eu@felipetonello.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
--cc=xingchao.wang@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome