mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Felipe Ferreri Tonello <eu@felipetonello.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mark Brown <broonie@kernel.org>,
	alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
	David Henningsson <david.henningsson@canonical.com>,
	Wang Xingchao <xingchao.wang@linux.intel.com>,
	Jaroslav Kysela <perex@perex.cz>
Subject: Re: [PATCH 1/4] ALSA: Added jack detection kcontrol support
Date: Wed, 31 Jul 2013 20:49:25 -0700	[thread overview]
Message-ID: <51F9DAC5.2000106@felipetonello.com> (raw)
In-Reply-To: <s5hfvuxfu5b.wl%tiwai@suse.de>

Hi Takashi,

On 07/29/2013 05:05 AM, Takashi Iwai wrote:
> At Sat, 27 Jul 2013 13:25:24 +0100,
> Mark Brown wrote:
>>
>> On Fri, Jul 26, 2013 at 04:13:40PM -0700, Felipe Tonello wrote:
>>> On Fri, Jul 26, 2013 at 3:48 PM, Mark Brown <broonie@kernel.org> wrote:
>>
>>>>>> What I'd expect to happen here is that for multi function jacks we
>>>>>> create a control per function if the controls are valid.
>>
>>> Ok, so the idea is just to change the control to type integer instead
>>> of boolean, right?
>>> Because as you say, the user will be able to check the type of jack
>>> based on the status value, right?
>>
>> It might be more idiomatic and more compatible with userspace to create
>> multiple controls for the jack, there was some discussion of this in the
>> past I think but I can't remember the result.
>
> I also forget the end result :)
>
> Another option would be to make an enum control, but multiple boolean
> controls are easier in the end.  The headset controls of HD-audio are
> represented in that way, too (because HD-audio specification can't
> tell better).

Yes. Thanks for the comment.

Felipe Tonello

  reply	other threads:[~2013-08-01  3:49 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-26 18:25 [PATCH 0/4] ALSA: Implement core jack support for kcontrol Felipe F. Tonello
2013-07-26 18:25 ` [PATCH 1/4] ALSA: Added jack detection kcontrol support Felipe F. Tonello
2013-07-26 18:46   ` Mark Brown
2013-07-26 19:04     ` Felipe Tonello
2013-07-26 18:54   ` Mark Brown
2013-07-26 19:10     ` Felipe Tonello
2013-07-26 22:48       ` Mark Brown
2013-07-26 23:13         ` Felipe Tonello
2013-07-27 12:25           ` Mark Brown
2013-07-29 12:05             ` Takashi Iwai
2013-08-01  3:49               ` Felipe Ferreri Tonello [this message]
2013-08-01  3:48             ` Felipe Ferreri Tonello
2013-08-01  8:24               ` Mark Brown
2013-07-26 18:25 ` [PATCH 2/4] ALSA: HDA: Updating jack implementation according new ALSA Jacks Felipe F. Tonello
2013-07-26 18:25 ` [PATCH 3/4] ALSA: SoC: " Felipe F. Tonello
2013-07-26 18:50   ` Mark Brown
2013-07-26 19:11     ` Felipe Tonello
2013-07-26 18:25 ` [PATCH 4/4] ALSA: oxygen: " Felipe F. Tonello
2013-07-26 18:56   ` Mark Brown
2013-07-26 19:02     ` Felipe Tonello
2013-07-26 22:45       ` Mark Brown
2013-07-26 22:48         ` Felipe Tonello
2013-07-29 12:10       ` Takashi Iwai
2013-08-01  3:51         ` Felipe Ferreri Tonello
2013-07-26 22:45 ` [PATCH v2 0/3] ALSA: Implement core jack support for kcontrol Felipe F. Tonello
2013-07-26 22:45 ` [PATCH v2 1/3] ALSA: Added jack detection kcontrol support Felipe F. Tonello
2013-07-29 14:19   ` Takashi Iwai
2013-08-01  3:52     ` Felipe Ferreri Tonello
2013-07-26 22:45 ` [PATCH v2 2/3] ALSA: pci: HDA/oxygen: Updating jack implementation according new ALSA Jacks Felipe F. Tonello
2013-07-26 22:45 ` [PATCH v2 3/3] ALSA: SoC: " Felipe F. Tonello
2013-07-29 15:03   ` Stephen Warren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=51F9DAC5.2000106@felipetonello.com \
    --to=eu@felipetonello.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=david.henningsson@canonical.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.de \
    --cc=xingchao.wang@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome