mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: abbasjasim <abbasjasim.aj@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: android: logger..c fixed a brace coding style issue
Date: Mon, 29 Jul 2013 11:20:49 -0700	[thread overview]
Message-ID: <20130729182049.GA18299@kroah.com> (raw)
In-Reply-To: <1375019271-10084-1-git-send-email-abbasjasim.AJ@gmail.com>

On Sun, Jul 28, 2013 at 04:47:51PM +0300, abbasjasim wrote:
> fixed a coding style issue.
> 
> Signed-off-by: Abbas J. Mohammed <abbasjasim.AJ@gmail.com>
> ---
>  drivers/staging/android/logger.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
> index ffc2d04..3d5180a 100644
> --- a/drivers/staging/android/logger.c
> +++ b/drivers/staging/android/logger.c
> @@ -81,8 +81,9 @@ static inline struct logger_log *file_get_log(struct file *file)
>  	if (file->f_mode & FMODE_READ) {
>  		struct logger_reader *reader = file->private_data;
>  		return reader->log;
> -	} else
> +	} else {
>  		return file->private_data;
> +	}

I think the existing code is just fine, no need for this patch.

thanks,

greg k-h

      reply	other threads:[~2013-07-29 18:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-28 13:47 abbasjasim
2013-07-29 18:20 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130729182049.GA18299@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=abbasjasim.aj@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome