* [PATCH] staging: android: logger..c fixed a brace coding style issue
@ 2013-07-28 13:47 abbasjasim
2013-07-29 18:20 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: abbasjasim @ 2013-07-28 13:47 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, abbasjasim
fixed a coding style issue.
Signed-off-by: Abbas J. Mohammed <abbasjasim.AJ@gmail.com>
---
drivers/staging/android/logger.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
index ffc2d04..3d5180a 100644
--- a/drivers/staging/android/logger.c
+++ b/drivers/staging/android/logger.c
@@ -81,8 +81,9 @@ static inline struct logger_log *file_get_log(struct file *file)
if (file->f_mode & FMODE_READ) {
struct logger_reader *reader = file->private_data;
return reader->log;
- } else
+ } else {
return file->private_data;
+ }
}
/*
--
1.8.1.2
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: android: logger..c fixed a brace coding style issue
2013-07-28 13:47 [PATCH] staging: android: logger..c fixed a brace coding style issue abbasjasim
@ 2013-07-29 18:20 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-07-29 18:20 UTC (permalink / raw)
To: abbasjasim; +Cc: devel, linux-kernel
On Sun, Jul 28, 2013 at 04:47:51PM +0300, abbasjasim wrote:
> fixed a coding style issue.
>
> Signed-off-by: Abbas J. Mohammed <abbasjasim.AJ@gmail.com>
> ---
> drivers/staging/android/logger.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/staging/android/logger.c b/drivers/staging/android/logger.c
> index ffc2d04..3d5180a 100644
> --- a/drivers/staging/android/logger.c
> +++ b/drivers/staging/android/logger.c
> @@ -81,8 +81,9 @@ static inline struct logger_log *file_get_log(struct file *file)
> if (file->f_mode & FMODE_READ) {
> struct logger_reader *reader = file->private_data;
> return reader->log;
> - } else
> + } else {
> return file->private_data;
> + }
I think the existing code is just fine, no need for this patch.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-07-29 18:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-07-28 13:47 [PATCH] staging: android: logger..c fixed a brace coding style issue abbasjasim
2013-07-29 18:20 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome