From: Borislav Petkov <bp@alien8.de>
To: Laszlo Ersek <lersek@redhat.com>
Cc: edk2-devel@lists.sourceforge.net,
David Woodhouse <dwmw2@infradead.org>,
linux-efi@vger.kernel.org, lkml <linux-kernel@vger.kernel.org>,
Gleb Natapov <gleb@redhat.com>,
Matthew Garrett <mjg59@srcf.ucam.org>,
Matt Fleming <matt@console-pimps.org>,
"Jordan Justen (Intel address)" <jordan.l.justen@intel.com>
Subject: Re: [edk2] Corrupted EFI region
Date: Thu, 8 Aug 2013 17:02:49 +0200 [thread overview]
Message-ID: <20130808150249.GB27974@pd.tnic> (raw)
In-Reply-To: <5202889C.2080608@redhat.com>
On Wed, Aug 07, 2013 at 07:49:16PM +0200, Laszlo Ersek wrote:
[…]
> Now, lines 01 to 05 *do not happen*.
>
> More precisely, they don't happen in the kernel. They happen in the
> firmware. Specifically, "OvmfPkg/Library/LoadLinuxLib/Linux.c".
>
> You're booting the kernel from the qemu command line. The kernel you
> run is also an "[o]ld kernel[] without EFI handover protocol". So what
> happens is, OVMF downloads the kernel image from qemu over fw_cfg,
> figures it's an old kernel...
Right, I think this is easier than having to go into the EFI shell each
time and run bzImage.efi. Unless there's a faster way to do that along
with passing it kernel command line parameters...
[…]
> In one sentence, efi_memblock_x86_reserve_range() expects that
> "boot_params.efi_info->efi_memmap" has been allocated as "loader data"
> (by whomever), but SetupLinuxMemmap() violates this by allocating the
> storage as "boot services data".
>
> This leads to double reservation attempts between
> efi_memblock_x86_reserve_range(), and efi_reserve_boot_services().
Ok, this makes sense.
> The attached edk2 patch should fix it. Please confirm.
>
> Thanks,
> Laszlo
>
> From 4a9e1f10fa2d06496f1983c25c47c6a1373d2f42 Mon Sep 17 00:00:00 2001
> From: Laszlo Ersek <lersek@redhat.com>
> Date: Wed, 7 Aug 2013 19:39:30 +0200
> Subject: [PATCH] OvmfPkg: allocate the EFI memory map for Linux as Loader Data
>
> In Linux, efi_memblock_x86_reserve_range() and efi_reserve_boot_services()
> expect that whoever allocates the EFI memmap allocates it in Loader Data
> type memory. Linux's own exit_boot()-->low_alloc() complies, but
> SetupLinuxMemmap() in LoadLinuxLib doesn't.
>
> The memory type discrepancy leads to efi_memblock_x86_reserve_range() and
> efi_reserve_boot_services() both trying to reserve the range backing the
> memmap, resulting in memmap entry truncation in
> efi_reserve_boot_services().
>
> This fix also makes this allocation consistent with all other persistent
> allocations in "OvmfPkg/Library/LoadLinuxLib/Linux.c".
>
> Contributed-under: TianoCore Contribution Agreement 1.0
>
> Signed-off-by: Laszlo Ersek <lersek@redhat.com>
Reported-and-tested-by: Borislav Petkov <bp@suse.de>
Great, thanks for this.
I guess we got that out of the way too. I finally can concentrate on my
patches again :-)
--
Regards/Gruss,
Boris.
Sent from a fat crate under my desk. Formatting is fine.
--
next prev parent reply other threads:[~2013-08-08 15:02 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 20:54 Borislav Petkov
2013-07-31 20:58 ` Matthew Garrett
2013-07-31 21:51 ` Borislav Petkov
2013-07-31 21:54 ` Matthew Garrett
2013-08-01 16:51 ` Borislav Petkov
2013-07-31 21:55 ` David Woodhouse
2013-08-01 16:49 ` Borislav Petkov
2013-08-05 11:27 ` [edk2] " Laszlo Ersek
2013-08-05 13:02 ` Borislav Petkov
2013-08-05 13:39 ` Laszlo Ersek
2013-08-05 14:03 ` Borislav Petkov
2013-08-05 14:27 ` Laszlo Ersek
2013-08-05 14:40 ` Borislav Petkov
2013-08-05 15:15 ` Laszlo Ersek
2013-08-05 15:34 ` James Bottomley
2013-08-05 16:27 ` Laszlo Ersek
2013-08-05 16:12 ` Borislav Petkov
2013-08-05 16:41 ` Laszlo Ersek
2013-08-05 16:47 ` Borislav Petkov
2013-08-05 17:00 ` Kinney, Michael D
2013-08-05 17:09 ` Laszlo Ersek
2013-08-05 21:26 ` Laszlo Ersek
2013-08-05 22:08 ` Borislav Petkov
2013-08-06 14:10 ` Borislav Petkov
2013-08-06 15:31 ` Laszlo Ersek
2013-08-07 15:19 ` Borislav Petkov
2013-08-07 17:23 ` Andrew Fish
2013-08-07 20:19 ` Matt Fleming
2013-08-07 20:24 ` Matt Fleming
2013-08-07 21:10 ` Andrew Fish
2013-08-07 21:23 ` Matthew Garrett
2013-08-08 10:17 ` Matt Fleming
2013-08-08 13:46 ` Andrew Fish
2013-09-02 8:19 ` Matt Fleming
2013-09-13 20:38 ` jerry.hoemann
2013-09-16 10:59 ` Matt Fleming
2013-09-16 11:50 ` Laszlo Ersek
2013-09-16 15:57 ` Josh Triplett
2013-09-16 16:25 ` Laszlo Ersek
2013-09-16 16:27 ` Matthew Garrett
2013-09-16 16:29 ` Josh Triplett
2013-09-18 19:24 ` jerry.hoemann
2013-09-20 9:06 ` Matt Fleming
2013-08-07 17:49 ` Laszlo Ersek
2013-08-08 15:02 ` Borislav Petkov [this message]
2013-08-08 21:45 ` Brian J. Johnson
2013-08-18 7:33 ` Jordan Justen
2013-08-05 15:50 ` Andrew Fish
2013-08-05 18:12 ` Borislav Petkov
2013-08-05 21:37 ` H. Peter Anvin
2013-08-05 21:41 ` Borislav Petkov
2013-08-05 21:49 ` H. Peter Anvin
2013-08-05 21:55 ` Laszlo Ersek
2013-08-05 22:52 ` James Bottomley
2013-08-06 7:26 ` Laszlo Ersek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130808150249.GB27974@pd.tnic \
--to=bp@alien8.de \
--cc=dwmw2@infradead.org \
--cc=edk2-devel@lists.sourceforge.net \
--cc=gleb@redhat.com \
--cc=jordan.l.justen@intel.com \
--cc=lersek@redhat.com \
--cc=linux-efi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=matt@console-pimps.org \
--cc=mjg59@srcf.ucam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®