Re: [PATCH v3 1/2] ALSA: Added jack detection KControl support

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 939 bytes --]

On Mon, Aug 12, 2013 at 12:39:10PM +0200, Takashi Iwai wrote:

> But, don't get me wrong: I'm not against the action itself, the
> removal of input jack support in HD-audio.  I myself did propose this
> once ago.  Again,  what's missing in your approach is the proper
> process.

> - Think whether removal of input-jack support is really needed for
>   HD-audio;
>   for example, if you integrate snd_jack stuff to support both
>   input-jack and kctl jack, HD-audio driver can use it solely instead
>   of calling snd_kctl stuff.  Then both input and kctl jacks will be
>   supported automagically.

I think this is the best approach - just get everything using jack.c for
all types of jack and deal with things there.  We've also got extcon
based reporting to consider, having a single place where all the
userspace interfaces are implemented will mean we can just add that.

This is why I put everything in jack.c in the first place :(

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]