mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Mark Brown <broonie@kernel.org>
Cc: "Felipe F. Tonello" <eu@felipetonello.com>,
	alsa-devel@alsa-project.org, Jaroslav Kysela <perex@perex.cz>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] ALSA: Added jack detection KControl support
Date: Thu, 08 Aug 2013 07:45:05 +0200	[thread overview]
Message-ID: <s5hzjssag7y.wl%tiwai@suse.de> (raw)
In-Reply-To: <20130807164509.GO6427@sirena.org.uk>

At Wed, 7 Aug 2013 17:45:09 +0100,
Mark Brown wrote:
> 
> On Fri, Aug 02, 2013 at 12:59:24AM -0700, Felipe F. Tonello wrote:
> 
> > +int jack_ctl_integer_info(struct snd_kcontrol *kcontrol,
> > +                          struct snd_ctl_elem_info *uinfo)
> > +{
> > +	uinfo->type = SNDRV_CTL_ELEM_TYPE_INTEGER;
> > +	uinfo->count = 0x10000U;
> > +	uinfo->value.integer.min = 0;
> > +	uinfo->value.integer.max = 0xffff;
> > +	return 0;
> > +}
> 
> I'd expected to see us creating multiple boolean controls here.  I don't
> have a great problem with doing things this way but it's surprising and
> I worry about confusing existing userspace, Takashi?

Yes, multiple boolean would make more sense.


thanks,

Takashi

  parent reply	other threads:[~2013-08-08  5:43 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-02  7:59 [PATCH v2 0/2] ALSA: Implement core jack support for kcontrol Felipe F. Tonello
2013-08-02  7:59 ` [PATCH v2 1/2] ALSA: Added jack detection KControl support Felipe F. Tonello
2013-08-07 16:45   ` Mark Brown
2013-08-07 23:06     ` Felipe Tonello
2013-08-08  5:45     ` Takashi Iwai [this message]
2013-08-09  6:21   ` [PATCH v3 " Felipe F. Tonello
2013-08-09 13:52     ` Takashi Iwai
2013-08-09 16:39       ` Mark Brown
2013-08-09 16:51         ` Takashi Iwai
2013-08-09 17:36       ` Felipe Tonello
2013-08-12 10:39         ` Takashi Iwai
2013-08-12 10:54           ` Mark Brown
2013-08-12 18:34           ` Felipe Tonello
2013-08-02  7:59 ` [PATCH v2 2/2] ALSA: SoC: Fix jack names according new API Felipe F. Tonello

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hzjssag7y.wl%tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=eu@felipetonello.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=perex@perex.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®