* [PATCH] Omnikey Cardman 4000: pull in ioctl.h in user header
@ 2013-08-16 18:07 Mike Frysinger
2013-08-22 22:55 ` Andrew Morton
0 siblings, 1 reply; 3+ messages in thread
From: Mike Frysinger @ 2013-08-16 18:07 UTC (permalink / raw)
To: linux-kernel, Andrew Morton; +Cc: laforge
This file uses the ioctl helpers (_IOR/_IOW/etc...), so include ioctl.h
for the definitions.
Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
include/uapi/linux/cm4000_cs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/uapi/linux/cm4000_cs.h b/include/uapi/linux/cm4000_cs.h
index bc51f77..1217f75 100644
--- a/include/uapi/linux/cm4000_cs.h
+++ b/include/uapi/linux/cm4000_cs.h
@@ -2,6 +2,7 @@
#define _UAPI_CM4000_H_
#include <linux/types.h>
+#include <linux/ioctl.h>
#define MAX_ATR 33
--
1.8.3.2
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Omnikey Cardman 4000: pull in ioctl.h in user header
2013-08-16 18:07 [PATCH] Omnikey Cardman 4000: pull in ioctl.h in user header Mike Frysinger
@ 2013-08-22 22:55 ` Andrew Morton
2013-08-24 21:54 ` Mike Frysinger
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Morton @ 2013-08-22 22:55 UTC (permalink / raw)
To: Mike Frysinger; +Cc: linux-kernel, laforge
On Fri, 16 Aug 2013 14:07:09 -0400 Mike Frysinger <vapier@gentoo.org> wrote:
> This file uses the ioctl helpers (_IOR/_IOW/etc...), so include ioctl.h
> for the definitions.
>
> ...
>
> --- a/include/uapi/linux/cm4000_cs.h
> +++ b/include/uapi/linux/cm4000_cs.h
> @@ -2,6 +2,7 @@
> #define _UAPI_CM4000_H_
>
> #include <linux/types.h>
> +#include <linux/ioctl.h>
>
> #define MAX_ATR 33
I'm assuming this fixes a build error under unknown circumstances, or
not, or something else?
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Omnikey Cardman 4000: pull in ioctl.h in user header
2013-08-22 22:55 ` Andrew Morton
@ 2013-08-24 21:54 ` Mike Frysinger
0 siblings, 0 replies; 3+ messages in thread
From: Mike Frysinger @ 2013-08-24 21:54 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, laforge
[-- Attachment #1: Type: Text/Plain, Size: 750 bytes --]
On Thursday 22 August 2013 18:55:45 Andrew Morton wrote:
> On Fri, 16 Aug 2013 14:07:09 -0400 Mike Frysinger wrote:
> > This file uses the ioctl helpers (_IOR/_IOW/etc...), so include ioctl.h
> > for the definitions.
> >
> > ...
> >
> > --- a/include/uapi/linux/cm4000_cs.h
> > +++ b/include/uapi/linux/cm4000_cs.h
> > @@ -2,6 +2,7 @@
> > #define _UAPI_CM4000_H_
> >
> > #include <linux/types.h>
> > +#include <linux/ioctl.h>
> >
> > #define MAX_ATR 33
>
> I'm assuming this fixes a build error under unknown circumstances, or
> not, or something else?
yes, it's to fix a build error. i don't have any specific source packages that
are known to fail though. just doing analysis of the headers by grep/eye.
-mike
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-24 21:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-16 18:07 [PATCH] Omnikey Cardman 4000: pull in ioctl.h in user header Mike Frysinger
2013-08-22 22:55 ` Andrew Morton
2013-08-24 21:54 ` Mike Frysinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®