* [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration
@ 2013-08-23 11:35 Sachin Kamat
2013-08-23 11:35 ` [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt Sachin Kamat
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Sachin Kamat @ 2013-08-23 11:35 UTC (permalink / raw)
To: linux-kernel; +Cc: lee.jones, sameo, sachin.kamat, linus.walleij
Silences the following warning:
drivers/mfd/db8500-prcmu.c:2322:25: warning:
non-ANSI function declaration of function 'prcmu_ac_sleep_req'
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mfd/db8500-prcmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 0d68eb1..8685872 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -2319,7 +2319,7 @@ unlock_and_return:
/**
* prcmu_ac_sleep_req - called when ARM no longer needs to talk to modem
*/
-void prcmu_ac_sleep_req()
+void prcmu_ac_sleep_req(void)
{
u32 val;
--
1.7.4.1
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt
2013-08-23 11:35 [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration Sachin Kamat
@ 2013-08-23 11:35 ` Sachin Kamat
2013-08-23 18:57 ` Linus Walleij
2013-08-27 8:28 ` Lee Jones
2013-08-23 18:57 ` [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration Linus Walleij
2013-08-27 8:27 ` Lee Jones
2 siblings, 2 replies; 6+ messages in thread
From: Sachin Kamat @ 2013-08-23 11:35 UTC (permalink / raw)
To: linux-kernel; +Cc: lee.jones, sameo, sachin.kamat, linus.walleij
clk_mgt is used only in this file. Make it static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mfd/db8500-prcmu.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/mfd/db8500-prcmu.c b/drivers/mfd/db8500-prcmu.c
index 8685872..53f371d 100644
--- a/drivers/mfd/db8500-prcmu.c
+++ b/drivers/mfd/db8500-prcmu.c
@@ -465,7 +465,7 @@ static DEFINE_SPINLOCK(clk_mgt_lock);
#define CLK_MGT_ENTRY(_name, _branch, _clk38div)[PRCMU_##_name] = \
{ (PRCM_##_name##_MGT), 0 , _branch, _clk38div}
-struct clk_mgt clk_mgt[PRCMU_NUM_REG_CLOCKS] = {
+static struct clk_mgt clk_mgt[PRCMU_NUM_REG_CLOCKS] = {
CLK_MGT_ENTRY(SGACLK, PLL_DIV, false),
CLK_MGT_ENTRY(UARTCLK, PLL_FIX, true),
CLK_MGT_ENTRY(MSP02CLK, PLL_FIX, true),
--
1.7.4.1
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt
2013-08-23 11:35 ` [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt Sachin Kamat
@ 2013-08-23 18:57 ` Linus Walleij
2013-08-27 8:28 ` Lee Jones
1 sibling, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2013-08-23 18:57 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, Lee Jones, Samuel Ortiz
On Fri, Aug 23, 2013 at 1:35 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> clk_mgt is used only in this file. Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt
2013-08-23 11:35 ` [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt Sachin Kamat
2013-08-23 18:57 ` Linus Walleij
@ 2013-08-27 8:28 ` Lee Jones
1 sibling, 0 replies; 6+ messages in thread
From: Lee Jones @ 2013-08-27 8:28 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, sameo, linus.walleij
On Fri, 23 Aug 2013, Sachin Kamat wrote:
> clk_mgt is used only in this file. Make it static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mfd/db8500-prcmu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied with Linus' Ack.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration
2013-08-23 11:35 [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration Sachin Kamat
2013-08-23 11:35 ` [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt Sachin Kamat
@ 2013-08-23 18:57 ` Linus Walleij
2013-08-27 8:27 ` Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Linus Walleij @ 2013-08-23 18:57 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, Lee Jones, Samuel Ortiz
On Fri, Aug 23, 2013 at 1:35 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Silences the following warning:
> drivers/mfd/db8500-prcmu.c:2322:25: warning:
> non-ANSI function declaration of function 'prcmu_ac_sleep_req'
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration
2013-08-23 11:35 [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration Sachin Kamat
2013-08-23 11:35 ` [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt Sachin Kamat
2013-08-23 18:57 ` [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration Linus Walleij
@ 2013-08-27 8:27 ` Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2013-08-27 8:27 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, sameo, linus.walleij
On Fri, 23 Aug 2013, Sachin Kamat wrote:
> Silences the following warning:
> drivers/mfd/db8500-prcmu.c:2322:25: warning:
> non-ANSI function declaration of function 'prcmu_ac_sleep_req'
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mfd/db8500-prcmu.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
Applied with Linus' Ack.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-08-27 8:28 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-23 11:35 [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration Sachin Kamat
2013-08-23 11:35 ` [PATCH 2/2] mfd: db8500-prcmu: Staticize clk_mgt Sachin Kamat
2013-08-23 18:57 ` Linus Walleij
2013-08-27 8:28 ` Lee Jones
2013-08-23 18:57 ` [PATCH 1/2] mfd: db8500-prcmu: Use ANSI function declaration Linus Walleij
2013-08-27 8:27 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®