* [PATCH 1/1] mfd: ab8500-debugfs: Staticize local variables
@ 2013-08-23 12:07 Sachin Kamat
2013-08-23 18:56 ` Linus Walleij
2013-08-27 8:29 ` Lee Jones
0 siblings, 2 replies; 3+ messages in thread
From: Sachin Kamat @ 2013-08-23 12:07 UTC (permalink / raw)
To: linux-kernel; +Cc: lee.jones, linus.walleij, sameo, sachin.kamat
Local variables referenced only in this file are made static.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/mfd/ab8500-debugfs.c | 8 ++++----
1 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/mfd/ab8500-debugfs.c b/drivers/mfd/ab8500-debugfs.c
index 7d1f1b0..a0afa64 100644
--- a/drivers/mfd/ab8500-debugfs.c
+++ b/drivers/mfd/ab8500-debugfs.c
@@ -159,7 +159,7 @@ static struct hwreg_cfg hwreg_cfg = {
static struct ab8500_prcmu_ranges *debug_ranges;
-struct ab8500_prcmu_ranges ab8500_debug_ranges[AB8500_NUM_BANKS] = {
+static struct ab8500_prcmu_ranges ab8500_debug_ranges[AB8500_NUM_BANKS] = {
[0x0] = {
.num_ranges = 0,
.range = NULL,
@@ -488,7 +488,7 @@ struct ab8500_prcmu_ranges ab8500_debug_ranges[AB8500_NUM_BANKS] = {
},
};
-struct ab8500_prcmu_ranges ab8505_debug_ranges[AB8500_NUM_BANKS] = {
+static struct ab8500_prcmu_ranges ab8505_debug_ranges[AB8500_NUM_BANKS] = {
[0x0] = {
.num_ranges = 0,
.range = NULL,
@@ -847,7 +847,7 @@ struct ab8500_prcmu_ranges ab8505_debug_ranges[AB8500_NUM_BANKS] = {
},
};
-struct ab8500_prcmu_ranges ab8540_debug_ranges[AB8500_NUM_BANKS] = {
+static struct ab8500_prcmu_ranges ab8540_debug_ranges[AB8500_NUM_BANKS] = {
[AB8500_M_FSM_RANK] = {
.num_ranges = 1,
.range = (struct ab8500_reg_range[]) {
@@ -1377,7 +1377,7 @@ void ab8500_dump_all_banks(struct device *dev)
/* Space for 500 registers. */
#define DUMP_MAX_REGS 700
-struct ab8500_register_dump
+static struct ab8500_register_dump
{
u8 bank;
u8 reg;
--
1.7.4.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mfd: ab8500-debugfs: Staticize local variables
2013-08-23 12:07 [PATCH 1/1] mfd: ab8500-debugfs: Staticize local variables Sachin Kamat
@ 2013-08-23 18:56 ` Linus Walleij
2013-08-27 8:29 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2013-08-23 18:56 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, Lee Jones, Samuel Ortiz
On Fri, Aug 23, 2013 at 2:07 PM, Sachin Kamat <sachin.kamat@linaro.org> wrote:
> Local variables referenced only in this file are made static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 1/1] mfd: ab8500-debugfs: Staticize local variables
2013-08-23 12:07 [PATCH 1/1] mfd: ab8500-debugfs: Staticize local variables Sachin Kamat
2013-08-23 18:56 ` Linus Walleij
@ 2013-08-27 8:29 ` Lee Jones
1 sibling, 0 replies; 3+ messages in thread
From: Lee Jones @ 2013-08-27 8:29 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, linus.walleij, sameo
On Fri, 23 Aug 2013, Sachin Kamat wrote:
> Local variables referenced only in this file are made static.
>
> Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> ---
> drivers/mfd/ab8500-debugfs.c | 8 ++++----
> 1 files changed, 4 insertions(+), 4 deletions(-)
Applied with Linus' Ack.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2013-08-27 8:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-08-23 12:07 [PATCH 1/1] mfd: ab8500-debugfs: Staticize local variables Sachin Kamat
2013-08-23 18:56 ` Linus Walleij
2013-08-27 8:29 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®