* Re: amd64_edac: Add ECC decoding support for newer F15h models
[not found] <20130904185224.67DFF660948@gitolite.kernel.org>
@ 2013-09-05 14:43 ` Dave Jones
2013-09-11 14:44 ` Borislav Petkov
0 siblings, 1 reply; 2+ messages in thread
From: Dave Jones @ 2013-09-05 14:43 UTC (permalink / raw)
To: Linux Kernel Mailing List; +Cc: Aravind.Gopalakrishnan
On Wed, Sep 04, 2013 at 06:52:24PM +0000, Linux Kernel wrote:
> Gitweb: http://git.kernel.org/linus/;a=commit;h=18b94f66f9537003cee30d475d79a57c58f1e1d8
> Commit: 18b94f66f9537003cee30d475d79a57c58f1e1d8
> Parent: 7d64ac6422092adbbdaa279ab32f9d4c90a84558
> Author: Aravind Gopalakrishnan <Aravind.Gopalakrishnan@amd.com>
> AuthorDate: Fri Aug 9 11:54:49 2013 -0500
> Committer: Borislav Petkov <bp@suse.de>
> CommitDate: Mon Aug 12 16:00:10 2013 +0200
>
> amd64_edac: Add ECC decoding support for newer F15h models
> +static int f15_m30h_match_to_this_node(struct amd64_pvt *pvt, unsigned range,
> + u64 sys_addr, int *chan_sel)
> +{
> + ...
> + u8 channel, alias_channel, leg_mmio_hole, dct_sel, dct_offset_en;
^^^^^^^^^^
> +
> + ....
> +
> + channel = f15_m30h_determine_channel(pvt, sys_addr, intlv_en,
> + num_dcts_intlv, dct_sel);
> +
> + /* Verify we stay within the MAX number of channels allowed */
> + if (channel > 4 || channel < 0)
> + return -EINVAL;
Channel will never be < 0, as it's unsigned.
Dave
^ permalink raw reply [flat|nested] 2+ messages in thread