mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: behanw@converseincode.com
Cc: Will Deacon <will.deacon@arm.com>,
	Wade Farnsworth <wade_farnsworth@mentor.com>,
	Will Drewry <wad@chromium.org>,
	"moderated list:ARM PORT" <linux-arm-kernel@lists.infradead.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/5] arm: LLVMLinux: Add current_stack_pointer macro for ARM
Date: Fri, 6 Sep 2013 23:20:27 +0100	[thread overview]
Message-ID: <20130906222027.GR6617@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1378502899-1241-2-git-send-email-behanw@converseincode.com>

On Fri, Sep 06, 2013 at 05:28:07PM -0400, behanw@converseincode.com wrote:
> From: Behan Webster <behanw@converseincode.com>
> 
> A macro to get the current stack pointer which allows for a single place in
> which to do so with ASM. Before this named registers (a gcc extension) was used
> to get the stack pointer. Using ASM is a more portable way of getting the stack
> pointer which works with both gcc and clang.  This macro is of the same name
> used in the X86 arch.

This will result in less optimal code - rather than the compiler being
able to mask directly with 'sp', it's going to have to use this bit of
assembly to first move it into another register.

Why do we want this change?

  parent reply	other threads:[~2013-09-06 22:26 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-06 21:28 [PATCH 0/5] arm: LLVMLinux: Add current_stack_pointer behanw
2013-09-06 21:28 ` [PATCH 1/5] arm: LLVMLinux: Add current_stack_pointer macro for ARM behanw
2013-09-06 22:12   ` Måns Rullgård
2013-09-06 22:20   ` Russell King - ARM Linux [this message]
2013-09-06 21:28 ` [PATCH 2/5] arm: LLVMLinux: use current_stack_pointer for percpu behanw
2013-09-06 22:22   ` Russell King - ARM Linux
2013-09-06 22:31   ` Måns Rullgård
2013-09-07  5:12   ` Nicolas Pitre
2013-09-09  9:59     ` Will Deacon
2013-09-06 21:28 ` [PATCH 3/5] arm: LLVMLinux: Use current_stack_pointer for return_address behanw
2013-09-06 21:28 ` [PATCH 4/5] arm: LLVMLinux: Use current_stack_pointer in save_stack_trace_tsk behanw
2013-09-06 21:28 ` [PATCH 5/5] arm: LLVMLinux: Use current_stack_pointer in unwind_backtrace behanw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130906222027.GR6617@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=behanw@converseincode.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=wad@chromium.org \
    --cc=wade_farnsworth@mentor.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®