* [PATCH] cpufreq: Detect spurious invocations of update_policy_cpu()
@ 2013-09-12 11:59 Srivatsa S. Bhat
2013-09-12 13:33 ` Viresh Kumar
0 siblings, 1 reply; 2+ messages in thread
From: Srivatsa S. Bhat @ 2013-09-12 11:59 UTC (permalink / raw)
To: rjw, viresh.kumar, swarren
Cc: cpufreq, linux-pm, linux-kernel, Srivatsa S. Bhat
The function update_policy_cpu() is expected to be called when the policy->cpu
of a cpufreq policy is to be changed: ie., the new CPU nominated to become the
policy->cpu is different from the old one.
Print a warning if it is invoked with new_cpu == old_cpu, since such an
invocation might hint at a faulty logic in the caller.
Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
---
drivers/cpufreq/cpufreq.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 43c24aa..2084132 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -949,7 +949,7 @@ static void cpufreq_policy_free(struct cpufreq_policy *policy)
static void update_policy_cpu(struct cpufreq_policy *policy, unsigned int cpu)
{
- if (cpu == policy->cpu)
+ if (WARN_ON(cpu == policy->cpu))
return;
policy->last_cpu = policy->cpu;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] cpufreq: Detect spurious invocations of update_policy_cpu()
2013-09-12 11:59 [PATCH] cpufreq: Detect spurious invocations of update_policy_cpu() Srivatsa S. Bhat
@ 2013-09-12 13:33 ` Viresh Kumar
0 siblings, 0 replies; 2+ messages in thread
From: Viresh Kumar @ 2013-09-12 13:33 UTC (permalink / raw)
To: Srivatsa S. Bhat
Cc: Rafael J. Wysocki, Stephen Warren, cpufreq, linux-pm,
Linux Kernel Mailing List
On 12 September 2013 17:29, Srivatsa S. Bhat
<srivatsa.bhat@linux.vnet.ibm.com> wrote:
> The function update_policy_cpu() is expected to be called when the policy->cpu
> of a cpufreq policy is to be changed: ie., the new CPU nominated to become the
> policy->cpu is different from the old one.
>
> Print a warning if it is invoked with new_cpu == old_cpu, since such an
> invocation might hint at a faulty logic in the caller.
>
> Suggested-by: Viresh Kumar <viresh.kumar@linaro.org>
> Signed-off-by: Srivatsa S. Bhat <srivatsa.bhat@linux.vnet.ibm.com>
> ---
>
> drivers/cpufreq/cpufreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-12 13:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-12 11:59 [PATCH] cpufreq: Detect spurious invocations of update_policy_cpu() Srivatsa S. Bhat
2013-09-12 13:33 ` Viresh Kumar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®