* [PATCH] MFD: ucb1x00-core: fix error return code in ucb1x00_probe()
@ 2013-09-11 11:20 Wei Yongjun
2013-09-12 15:43 ` Lee Jones
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2013-09-11 11:20 UTC (permalink / raw)
To: sameo, lee.jones; +Cc: yongjun_wei, linux-kernel
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Fix to return a negative error code in the irq alloc error handling
case instead of 0, as done elsewhere in this function.
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
---
drivers/mfd/ucb1x00-core.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mfd/ucb1x00-core.c b/drivers/mfd/ucb1x00-core.c
index b7cf98f..10f2e8d 100644
--- a/drivers/mfd/ucb1x00-core.c
+++ b/drivers/mfd/ucb1x00-core.c
@@ -551,6 +551,7 @@ static int ucb1x00_probe(struct mcp *mcp)
if (ucb->irq_base < 0) {
dev_err(&ucb->dev, "unable to allocate 16 irqs: %d\n",
ucb->irq_base);
+ ret = ucb->irq_base;
goto err_irq_alloc;
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] MFD: ucb1x00-core: fix error return code in ucb1x00_probe()
2013-09-11 11:20 [PATCH] MFD: ucb1x00-core: fix error return code in ucb1x00_probe() Wei Yongjun
@ 2013-09-12 15:43 ` Lee Jones
0 siblings, 0 replies; 2+ messages in thread
From: Lee Jones @ 2013-09-12 15:43 UTC (permalink / raw)
To: Wei Yongjun; +Cc: sameo, yongjun_wei, linux-kernel
On Wed, 11 Sep 2013, Wei Yongjun wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fix to return a negative error code in the irq alloc error handling
> case instead of 0, as done elsewhere in this function.
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
> ---
> drivers/mfd/ucb1x00-core.c | 1 +
> 1 file changed, 1 insertion(+)
Applied, thanks.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-12 15:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-11 11:20 [PATCH] MFD: ucb1x00-core: fix error return code in ucb1x00_probe() Wei Yongjun
2013-09-12 15:43 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®