* [PATCH] adjust the error labels to make it clear
@ 2013-09-17 9:15 baisong zhong
2013-09-17 11:13 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: baisong zhong @ 2013-09-17 9:15 UTC (permalink / raw)
To: gregkh; +Cc: linux-kernel, zhongbaisong
From: zhongbaisong <baisong.zhong@gmail.com>
Signed-off-by: zhongbaisong <baisong.zhong@gmail.com>
---
fs/sysfs/mount.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c
index afd8327..f6681a6 100644
--- a/fs/sysfs/mount.c
+++ b/fs/sysfs/mount.c
@@ -182,12 +182,12 @@ int __init sysfs_init(void)
}
} else
goto out_err;
-out:
- return err;
+
out_err:
kmem_cache_destroy(sysfs_dir_cachep);
sysfs_dir_cachep = NULL;
- goto out;
+out:
+ return err;
}
#undef sysfs_get
--
1.7.0.4
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] adjust the error labels to make it clear
2013-09-17 9:15 [PATCH] adjust the error labels to make it clear baisong zhong
@ 2013-09-17 11:13 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2013-09-17 11:13 UTC (permalink / raw)
To: baisong zhong; +Cc: linux-kernel
On Tue, Sep 17, 2013 at 05:15:13PM +0800, baisong zhong wrote:
> From: zhongbaisong <baisong.zhong@gmail.com>
>
> Signed-off-by: zhongbaisong <baisong.zhong@gmail.com>
I need a changelog description in here, as to why you are making this
change, your Subject: is not descriptive at all. What is being made
"clear"?
> ---
> fs/sysfs/mount.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/fs/sysfs/mount.c b/fs/sysfs/mount.c
> index afd8327..f6681a6 100644
> --- a/fs/sysfs/mount.c
> +++ b/fs/sysfs/mount.c
> @@ -182,12 +182,12 @@ int __init sysfs_init(void)
> }
> } else
> goto out_err;
> -out:
> - return err;
> +
> out_err:
> kmem_cache_destroy(sysfs_dir_cachep);
> sysfs_dir_cachep = NULL;
> - goto out;
> +out:
> + return err;
You tested this patch right? Are you sure? Really really sure?
greg "I don't think you tested this" k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2013-09-17 11:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-17 9:15 [PATCH] adjust the error labels to make it clear baisong zhong
2013-09-17 11:13 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome