From: Tejun Heo <tj@kernel.org>
To: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk,
seiji.aguchi@hds.com, vgoyal@redhat.com, majianpeng@gmail.com
Subject: Re: [PATCH v2 2/2] elevator: acquire q->sysfs_lock in elevator_change()
Date: Sun, 22 Sep 2013 13:00:05 -0400 [thread overview]
Message-ID: <20130922170005.GE30946@htj.dyndns.org> (raw)
In-Reply-To: <20130830224716.21812.99333.stgit@hds.com>
On Fri, Aug 30, 2013 at 06:47:16PM -0400, Tomoki Sekiyama wrote:
> Add locking of q->sysfs_lock into elevator_change() (an exported function)
> to ensure it is held to protect q->elevator from elevator_init(), even if
> elevator_change() is called from non-sysfs paths.
> sysfs path (elv_iosched_store) uses __elevator_change(), non-locking
> version, as the lock is already taken by elv_iosched_store().
>
> Signed-off-by: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
Acked-by: Tejun Heo <tj@kernel.org>
Thanks.
--
tejun
next prev parent reply other threads:[~2013-09-22 17:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-30 22:47 [PATCH v2 1/2] elevator: Fix a race in elevator switching and md device initialization Tomoki Sekiyama
2013-08-30 22:47 ` [PATCH v2 2/2] elevator: acquire q->sysfs_lock in elevator_change() Tomoki Sekiyama
2013-09-22 17:00 ` Tejun Heo [this message]
2013-09-06 15:01 ` [PATCH v2 1/2] elevator: Fix a race in elevator switching and md device initialization Tomoki Sekiyama
2013-09-22 17:04 ` Tejun Heo
2013-09-23 20:11 ` Tomoki Sekiyama
2013-09-23 20:14 ` Tejun Heo
2013-10-09 22:36 ` Tomoki Sekiyama
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130922170005.GE30946@htj.dyndns.org \
--to=tj@kernel.org \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=majianpeng@gmail.com \
--cc=seiji.aguchi@hds.com \
--cc=tomoki.sekiyama@hds.com \
--cc=vgoyal@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®