mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Tomoki Sekiyama <tomoki.sekiyama@hds.com>
To: Tejun Heo <tj@kernel.org>, "axboe@kernel.dk" <axboe@kernel.dk>,
	"vgoyal@redhat.com" <vgoyal@redhat.com>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>,
	"majianpeng@gmail.com" <majianpeng@gmail.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 1/2] elevator: Fix a race in elevator switching and md device initialization
Date: Wed, 9 Oct 2013 22:36:39 +0000	[thread overview]
Message-ID: <CE7B51CA.7DB9%Tomoki.Sekiyama@hds.com> (raw)
In-Reply-To: <20130923201412.GA28667@mtj.dyndns.org>

Hi all,


Is this patchset going to be merged into 3.12?

Thanks,
-- 
Tomoki

On 9/23/13 16:14 , "Tejun Heo" <tj@kernel.org> wrote:

>Hello,
>
>On Mon, Sep 23, 2013 at 08:11:55PM +0000, Tomoki Sekiyama wrote:
>> >Hmm... why aren't we just changing elevator_init() to grab sysfs_lock
>> >where necessary?
>> 
>> The locking cannot be moved into elevator_init() because it is called
>> from elevator_switch() path, where the request_queue's sysfs_lock is
>> already taken.
>> 
>> > It'd be more consistent with elevator_exit() that way.
>> 
>> What elevator_exit() locks is elevator_queue's sysfs_lock, not
>> request_queue's sysfs_lock. What we need here is request_queue's
>> sysfs_lock.
>
>Ah, okay.
>
> Reviewed-by: Tejun Heo <tj@kernel.org>
>
>Thanks.
>
>-- 
>tejun


      reply	other threads:[~2013-10-09 22:41 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30 22:47 Tomoki Sekiyama
2013-08-30 22:47 ` [PATCH v2 2/2] elevator: acquire q->sysfs_lock in elevator_change() Tomoki Sekiyama
2013-09-22 17:00   ` Tejun Heo
2013-09-06 15:01 ` [PATCH v2 1/2] elevator: Fix a race in elevator switching and md device initialization Tomoki Sekiyama
2013-09-22 17:04 ` Tejun Heo
2013-09-23 20:11   ` Tomoki Sekiyama
2013-09-23 20:14     ` Tejun Heo
2013-10-09 22:36       ` Tomoki Sekiyama [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CE7B51CA.7DB9%Tomoki.Sekiyama@hds.com \
    --to=tomoki.sekiyama@hds.com \
    --cc=axboe@kernel.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=majianpeng@gmail.com \
    --cc=seiji.aguchi@hds.com \
    --cc=tj@kernel.org \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®