* [PATCH] ARC: Use clockevents_config_and_register over clockevents_register_device
@ 2013-09-24 21:05 Uwe Kleine-König
2013-09-26 12:01 ` Vineet Gupta
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2013-09-24 21:05 UTC (permalink / raw)
To: Vineet Gupta; +Cc: linux-kernel, Thomas Gleixner
clockevents_config_and_register is more clever and correct than doing it
by hand; so use it.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arc/kernel/time.c | 7 ++-----
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/arch/arc/kernel/time.c b/arch/arc/kernel/time.c
index 0e51e69..273df8e 100644
--- a/arch/arc/kernel/time.c
+++ b/arch/arc/kernel/time.c
@@ -227,12 +227,9 @@ void __attribute__((weak)) arc_local_timer_setup(unsigned int cpu)
{
struct clock_event_device *clk = &per_cpu(arc_clockevent_device, cpu);
- clockevents_calc_mult_shift(clk, arc_get_core_freq(), 5);
-
- clk->max_delta_ns = clockevent_delta2ns(ARC_TIMER_MAX, clk);
clk->cpumask = cpumask_of(cpu);
-
- clockevents_register_device(clk);
+ clockevents_config_and_register(clk, arc_get_core_freq(),
+ 0, ARC_TIMER_MAX)
/*
* setup the per-cpu timer IRQ handler - for all cpus
--
1.8.4.rc3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] ARC: Use clockevents_config_and_register over clockevents_register_device
2013-09-24 21:05 [PATCH] ARC: Use clockevents_config_and_register over clockevents_register_device Uwe Kleine-König
@ 2013-09-26 12:01 ` Vineet Gupta
2013-09-27 8:17 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Vineet Gupta @ 2013-09-26 12:01 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kernel, Thomas Gleixner
On 09/25/2013 02:35 AM, Uwe Kleine-König wrote:
> clockevents_config_and_register is more clever and correct than doing it
> by hand; so use it.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Acked-by: Vineet Gupta <vgupta@synopsys.com>
Thx for the fix.
-Vineet
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARC: Use clockevents_config_and_register over clockevents_register_device
2013-09-26 12:01 ` Vineet Gupta
@ 2013-09-27 8:17 ` Uwe Kleine-König
2013-09-27 8:26 ` Vineet Gupta
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2013-09-27 8:17 UTC (permalink / raw)
To: Vineet Gupta; +Cc: linux-kernel, kernel, Thomas Gleixner
On Thu, Sep 26, 2013 at 12:01:49PM +0000, Vineet Gupta wrote:
> On 09/25/2013 02:35 AM, Uwe Kleine-König wrote:
> > clockevents_config_and_register is more clever and correct than doing it
> > by hand; so use it.
> >
> > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>
> Acked-by: Vineet Gupta <vgupta@synopsys.com>
Thanks for the ack, but I expected that it will be you who takes that
patch. Am I wrong? Who will take it instead?
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARC: Use clockevents_config_and_register over clockevents_register_device
2013-09-27 8:17 ` Uwe Kleine-König
@ 2013-09-27 8:26 ` Vineet Gupta
2013-09-27 8:52 ` Uwe Kleine-König
0 siblings, 1 reply; 6+ messages in thread
From: Vineet Gupta @ 2013-09-27 8:26 UTC (permalink / raw)
To: Uwe Kleine-König; +Cc: linux-kernel, kernel, Thomas Gleixner
On 09/27/2013 01:47 PM, Uwe Kleine-König wrote:
> On Thu, Sep 26, 2013 at 12:01:49PM +0000, Vineet Gupta wrote:
>> On 09/25/2013 02:35 AM, Uwe Kleine-König wrote:
>>> clockevents_config_and_register is more clever and correct than doing it
>>> by hand; so use it.
>>>
>>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
>> Acked-by: Vineet Gupta <vgupta@synopsys.com>
> Thanks for the ack, but I expected that it will be you who takes that
> patch. Am I wrong? Who will take it instead?
Well that really depends - if there's a series of such fixes, people generally
route it thru mm or some such.
But, sure I can take it.
Thx again,
-Vineet
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARC: Use clockevents_config_and_register over clockevents_register_device
2013-09-27 8:26 ` Vineet Gupta
@ 2013-09-27 8:52 ` Uwe Kleine-König
2013-09-27 9:00 ` Vineet Gupta
0 siblings, 1 reply; 6+ messages in thread
From: Uwe Kleine-König @ 2013-09-27 8:52 UTC (permalink / raw)
To: Vineet Gupta; +Cc: linux-kernel, kernel, Thomas Gleixner
Hello,
On Fri, Sep 27, 2013 at 08:26:58AM +0000, Vineet Gupta wrote:
> On 09/27/2013 01:47 PM, Uwe Kleine-König wrote:
> > On Thu, Sep 26, 2013 at 12:01:49PM +0000, Vineet Gupta wrote:
> >> On 09/25/2013 02:35 AM, Uwe Kleine-König wrote:
> >>> clockevents_config_and_register is more clever and correct than doing it
> >>> by hand; so use it.
> >>>
> >>> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> >> Acked-by: Vineet Gupta <vgupta@synopsys.com>
> > Thanks for the ack, but I expected that it will be you who takes that
> > patch. Am I wrong? Who will take it instead?
>
> Well that really depends - if there's a series of such fixes, people generally
> route it thru mm or some such.
I still have a few such fixes in the queue, but as they are all
independant of each other I think it would be best if you took it.
Thanks
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | http://www.pengutronix.de/ |
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2013-09-27 9:05 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-24 21:05 [PATCH] ARC: Use clockevents_config_and_register over clockevents_register_device Uwe Kleine-König
2013-09-26 12:01 ` Vineet Gupta
2013-09-27 8:17 ` Uwe Kleine-König
2013-09-27 8:26 ` Vineet Gupta
2013-09-27 8:52 ` Uwe Kleine-König
2013-09-27 9:00 ` Vineet Gupta
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®