From: Peter Zijlstra <peterz@infradead.org>
To: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Cc: mingo@kernel.org, hpa@zytor.com, linux-kernel@vger.kernel.org,
tglx@linutronix.de, linux-tip-commits@vger.kernel.org,
Fengguang Wu <fengguang.wu@intel.com>,
Huang Ying <ying.huang@intel.com>,
lkp@linux.intel.com
Subject: Re: [tip:sched/core] sched: Add NEED_RESCHED to the preempt_count
Date: Fri, 27 Sep 2013 13:57:22 +0200 [thread overview]
Message-ID: <20130927115722.GM3657@laptop.programming.kicks-ass.net> (raw)
In-Reply-To: <20130927091427.GE24743@yliu-dev.sh.intel.com>
On Fri, Sep 27, 2013 at 05:14:27PM +0800, Yuanhan Liu wrote:
> On Wed, Sep 25, 2013 at 09:38:38AM -0700, tip-bot for Peter Zijlstra wrote:
> > Commit-ID: f27dde8deef33c9e58027df11ceab2198601d6a6
> > Gitweb: http://git.kernel.org/tip/f27dde8deef33c9e58027df11ceab2198601d6a6
> > Author: Peter Zijlstra <peterz@infradead.org>
> > AuthorDate: Wed, 14 Aug 2013 14:55:31 +0200
> > Committer: Ingo Molnar <mingo@kernel.org>
> > CommitDate: Wed, 25 Sep 2013 14:07:49 +0200
> >
> > sched: Add NEED_RESCHED to the preempt_count
>
> Hi Peter,
>
> FYI, here we found a pigz regression by this commit.
I just can't help myself; but pigs aren't supposed to fly anyway! :-)
> Here is a list all of changed stats by this commit and it's parent 4a2b4b222743bb07fedf985b884550f2ca067ea9:
>
> time.involuntary_context_switches [ 3184 - 4753 ] [ 5.536e+05 - 5.9042e+05 ]
> time.voluntary_context_switches [ 84559 - 1.2223e+05 ] [ 1.1008e+07 - 1.1092e+07 ]
Gah, that looks like it completely wrecked preemptions.
What kind of PREEMPT Kconfig options do you use? Or rather; could you
attach your .config?
next prev parent reply other threads:[~2013-09-27 11:57 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-25 16:38 tip-bot for Peter Zijlstra
2013-09-27 9:14 ` Yuanhan Liu
2013-09-27 11:57 ` Peter Zijlstra [this message]
2013-09-27 12:13 ` Fengguang Wu
2013-09-27 12:20 ` Fengguang Wu
2013-09-27 15:29 ` [PATCH] ftrace, sched: Add TRACE_FLAG_PREEMPT_RESCHED Peter Zijlstra
2013-10-04 8:09 ` Peter Zijlstra
2013-10-04 14:53 ` Steven Rostedt
2013-10-04 15:16 ` Peter Zijlstra
2013-10-04 15:25 ` Steven Rostedt
2013-10-04 15:28 ` Peter Zijlstra
2013-10-04 15:57 ` Steven Rostedt
2013-10-04 16:28 ` Peter Zijlstra
2013-11-11 17:52 ` [tip:sched/core] " tip-bot for Peter Zijlstra
2013-11-06 16:37 ` [PATCH] " Steven Rostedt
2013-11-06 16:45 ` Peter Zijlstra
2013-11-06 16:58 ` Steven Rostedt
2013-11-06 17:23 ` Peter Zijlstra
2013-09-27 15:30 ` [PATCH] sched: Revert need_resched() to look at TIF_NEED_RESCHED Peter Zijlstra
2013-09-28 8:28 ` [tip:sched/core] " tip-bot for Peter Zijlstra
2013-12-09 6:41 ` [PATCH] " Aneesh Kumar K.V
2013-12-10 15:52 ` Peter Zijlstra
2013-11-28 13:26 ` [PATCH] sched: Remove PREEMPT_NEED_RESCHED from generic code Peter Zijlstra
2013-11-28 15:24 ` Alexander Graf
2013-12-09 6:29 ` Benjamin Herrenschmidt
2013-12-12 9:51 ` [tip:sched/urgent] " tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130927115722.GM3657@laptop.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=fengguang.wu@intel.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-tip-commits@vger.kernel.org \
--cc=lkp@linux.intel.com \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
--cc=yuanhan.liu@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome