From: Mark Brown <broonie@kernel.org>
To: Sachin Kamat <sachin.kamat@linaro.org>
Cc: linux-kernel@vger.kernel.org, lgirdwood@gmail.com
Subject: Re: [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr
Date: Mon, 30 Sep 2013 12:01:25 +0100 [thread overview]
Message-ID: <20130930110125.GY19304@sirena.org.uk> (raw)
In-Reply-To: <1380531434-15875-1-git-send-email-sachin.kamat@linaro.org>
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On Mon, Sep 30, 2013 at 02:27:13PM +0530, Sachin Kamat wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
It seems like good practice to include these even if they're not
currently doing anything - for example, if ACPI support were added to
the driver then you could get an ACPI kernel OF disabled.
Note that one of the things these macros are supposed to do (but don't
yet IIRC) is allow for dead code elimination to discard references to
things automatically even without the being ifdefed out.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-09-30 11:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-30 8:57 Sachin Kamat
2013-09-30 8:57 ` [PATCH 2/2] regulator: twl: " Sachin Kamat
2013-09-30 11:01 ` Mark Brown [this message]
2013-09-30 11:52 ` [PATCH 1/2] regulator: ti-abb: " Sachin Kamat
2013-09-30 16:08 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130930110125.GY19304@sirena.org.uk \
--to=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®