* [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr
@ 2013-09-30 8:57 Sachin Kamat
2013-09-30 8:57 ` [PATCH 2/2] regulator: twl: " Sachin Kamat
2013-09-30 11:01 ` [PATCH 1/2] regulator: ti-abb: " Mark Brown
0 siblings, 2 replies; 5+ messages in thread
From: Sachin Kamat @ 2013-09-30 8:57 UTC (permalink / raw)
To: linux-kernel; +Cc: broonie, lgirdwood, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/regulator/ti-abb-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/ti-abb-regulator.c b/drivers/regulator/ti-abb-regulator.c
index 8c2a819..64d6322 100644
--- a/drivers/regulator/ti-abb-regulator.c
+++ b/drivers/regulator/ti-abb-regulator.c
@@ -855,7 +855,7 @@ static struct platform_driver ti_abb_driver = {
.driver = {
.name = "ti_abb",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(ti_abb_of_match),
+ .of_match_table = ti_abb_of_match,
},
};
module_platform_driver(ti_abb_driver);
--
1.7.9.5
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH 2/2] regulator: twl: Remove redundant of_match_ptr
2013-09-30 8:57 [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr Sachin Kamat
@ 2013-09-30 8:57 ` Sachin Kamat
2013-09-30 11:01 ` [PATCH 1/2] regulator: ti-abb: " Mark Brown
1 sibling, 0 replies; 5+ messages in thread
From: Sachin Kamat @ 2013-09-30 8:57 UTC (permalink / raw)
To: linux-kernel; +Cc: broonie, lgirdwood, sachin.kamat
The data structure of_match_ptr() protects is always compiled in.
Hence of_match_ptr() is not needed.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
---
drivers/regulator/twl-regulator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/regulator/twl-regulator.c b/drivers/regulator/twl-regulator.c
index 78aae4c..b764311 100644
--- a/drivers/regulator/twl-regulator.c
+++ b/drivers/regulator/twl-regulator.c
@@ -1233,7 +1233,7 @@ static struct platform_driver twlreg_driver = {
.driver = {
.name = "twl_reg",
.owner = THIS_MODULE,
- .of_match_table = of_match_ptr(twl_of_match),
+ .of_match_table = twl_of_match,
},
};
--
1.7.9.5
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr
2013-09-30 8:57 [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr Sachin Kamat
2013-09-30 8:57 ` [PATCH 2/2] regulator: twl: " Sachin Kamat
@ 2013-09-30 11:01 ` Mark Brown
2013-09-30 11:52 ` Sachin Kamat
1 sibling, 1 reply; 5+ messages in thread
From: Mark Brown @ 2013-09-30 11:01 UTC (permalink / raw)
To: Sachin Kamat; +Cc: linux-kernel, lgirdwood
[-- Attachment #1: Type: text/plain, Size: 561 bytes --]
On Mon, Sep 30, 2013 at 02:27:13PM +0530, Sachin Kamat wrote:
> The data structure of_match_ptr() protects is always compiled in.
> Hence of_match_ptr() is not needed.
It seems like good practice to include these even if they're not
currently doing anything - for example, if ACPI support were added to
the driver then you could get an ACPI kernel OF disabled.
Note that one of the things these macros are supposed to do (but don't
yet IIRC) is allow for dead code elimination to discard references to
things automatically even without the being ifdefed out.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr
2013-09-30 11:01 ` [PATCH 1/2] regulator: ti-abb: " Mark Brown
@ 2013-09-30 11:52 ` Sachin Kamat
2013-09-30 16:08 ` Mark Brown
0 siblings, 1 reply; 5+ messages in thread
From: Sachin Kamat @ 2013-09-30 11:52 UTC (permalink / raw)
To: Mark Brown; +Cc: LKML, Liam Girdwood
On 30 September 2013 16:31, Mark Brown <broonie@kernel.org> wrote:
> On Mon, Sep 30, 2013 at 02:27:13PM +0530, Sachin Kamat wrote:
>
> Note that one of the things these macros are supposed to do (but don't
> yet IIRC) is allow for dead code elimination to discard references to
> things automatically even without the being ifdefed out.
Yes that is correct. However, in this particular case all that
of_match_ptr() does
is make the pointer NULL if CONFIG_OF is disabled else assign it as
is. Since CONFIG_OF
is not used in these files, I thought it would be an appropriate cleanup.
--
With warm regards,
Sachin
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr
2013-09-30 11:52 ` Sachin Kamat
@ 2013-09-30 16:08 ` Mark Brown
0 siblings, 0 replies; 5+ messages in thread
From: Mark Brown @ 2013-09-30 16:08 UTC (permalink / raw)
To: Sachin Kamat; +Cc: LKML, Liam Girdwood
[-- Attachment #1: Type: text/plain, Size: 830 bytes --]
On Mon, Sep 30, 2013 at 05:22:19PM +0530, Sachin Kamat wrote:
> On 30 September 2013 16:31, Mark Brown <broonie@kernel.org> wrote:
> > Note that one of the things these macros are supposed to do (but don't
> > yet IIRC) is allow for dead code elimination to discard references to
> > things automatically even without the being ifdefed out.
> Yes that is correct. However, in this particular case all that
> of_match_ptr() does
> is make the pointer NULL if CONFIG_OF is disabled else assign it as
> is. Since CONFIG_OF
> is not used in these files, I thought it would be an appropriate cleanup.
Yes, it's not a completely silly idea but unlike something like removing
totally empty functions it's something that doesn't cost us anything and
which we might want in future. Right now the drivers only run on OF
systems though.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-09-30 16:09 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-09-30 8:57 [PATCH 1/2] regulator: ti-abb: Remove redundant of_match_ptr Sachin Kamat
2013-09-30 8:57 ` [PATCH 2/2] regulator: twl: " Sachin Kamat
2013-09-30 11:01 ` [PATCH 1/2] regulator: ti-abb: " Mark Brown
2013-09-30 11:52 ` Sachin Kamat
2013-09-30 16:08 ` Mark Brown
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®