From: Kim Phillips <kim.phillips@linaro.org>
To: taras.kondratiuk@linaro.org
Cc: sameo@linux.intel.com, lee.jones@linaro.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
linaro-networking@linaro.org, d.xie@sta.samsung.com
Subject: Re: [LNG] [PATCH] mfd: twl6030: Fix endianness problem in IRQ handler
Date: Wed, 2 Oct 2013 11:43:59 -0500 [thread overview]
Message-ID: <20131002114359.681cbdf92bd683373f07cca2@linaro.org> (raw)
In-Reply-To: <1380712124-20666-1-git-send-email-taras.kondratiuk@linaro.org>
On Wed, 2 Oct 2013 14:08:44 +0300
Taras Kondratiuk <taras.kondratiuk@linaro.org> wrote:
> From: Danke Xie <d.xie@sta.samsung.com>
>
> The current TWL 6030 IRQ handler assumes little endianness.
> This change makes it endian-neutral.
>
> Signed-off-by: Danke Xie <d.xie@sta.samsung.com>
> Signed-off-by: Taras Kondratiuk <taras.kondratiuk@linaro.org>
> ---
this patch causes a new sparse warning:
make C=2 CF="-D__CHECK_ENDIAN__" drivers/mfd/twl6030-irq.o
...
CHECK drivers/mfd/twl6030-irq.c
drivers/mfd/twl6030-irq.c:200:19: warning: cast to restricted __le32
does int_sts in the sts union need to be defined as __le32?
Thanks,
Kim
next prev parent reply other threads:[~2013-10-02 16:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-10-02 11:08 Taras Kondratiuk
2013-10-02 16:43 ` Kim Phillips [this message]
2013-10-02 21:08 ` [LNG] " Taras Kondratiuk
2013-10-03 23:00 ` [PATCH v2] " Taras Kondratiuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20131002114359.681cbdf92bd683373f07cca2@linaro.org \
--to=kim.phillips@linaro.org \
--cc=d.xie@sta.samsung.com \
--cc=lee.jones@linaro.org \
--cc=linaro-networking@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=taras.kondratiuk@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®